From 71cfa1b5caae4da42c0c2177ebe08c46e714b315 Mon Sep 17 00:00:00 2001 From: Gerrit User 30674 <30674@4a232e18-c5a9-48ee-94c0-e04e7cca6543> Date: Tue, 21 Nov 2023 13:17:27 +0000 Subject: [PATCH] Update patch set 17 Patch Set 17: (1 comment) Patch-set: 17 Attention: {"person_ident":"Gerrit User 28609 \u003c28609@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_30674\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 30674 \u003c30674@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_30674\u003e replied on the change"} --- 4664bd127ff0051cc22feb7ba54380e47a700da5 | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/4664bd127ff0051cc22feb7ba54380e47a700da5 b/4664bd127ff0051cc22feb7ba54380e47a700da5 index 1f3affc6..7a473e8e 100644 --- a/4664bd127ff0051cc22feb7ba54380e47a700da5 +++ b/4664bd127ff0051cc22feb7ba54380e47a700da5 @@ -176,6 +176,30 @@ "revId": "4664bd127ff0051cc22feb7ba54380e47a700da5", "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" }, + { + "unresolved": true, + "key": { + "uuid": "8b143cd9_f8c3cd2e", + "filename": "octavia_tempest_plugin/tests/scenario/v2/test_backup_members.py", + "patchSetId": 6 + }, + "lineNbr": 49, + "author": { + "id": 30674 + }, + "writtenOn": "2023-11-21T13:17:27Z", + "side": 1, + "message": "For example, the traffic ops tests are also running the IPv6 and IPv4 tests in the job [1]. I got inspired by those tests so I concluded that it should be ok.\n\nAm I missing something or should we fix this also for the traffic ops tests?\n\nI\u0027m not sure about this but I think that in this case, IP_VERSION is more important than SERVICE_IP_VERSION (?). By default, IP_VERSION is set to 6+4 which means dual-stack openstack [2].\n\nThank you Arkady for looking at this again:). \n\n[1] https://opendev.org/openstack/octavia-tempest-plugin/src/commit/5b2eca40a886ec3fc7c50605925a727247993612/octavia_tempest_plugin/tests/scenario/v2/test_traffic_ops.py#L61\n[2] https://opendev.org/openstack/devstack/src/commit/bb0c273697bf54dd569ad38e459cd161b62f96cb/lib/neutron_plugins/services/l3#L3", + "parentUuid": "d39aab47_646162b5", + "range": { + "startLine": 49, + "startChar": 8, + "endLine": 49, + "endChar": 22 + }, + "revId": "4664bd127ff0051cc22feb7ba54380e47a700da5", + "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" + }, { "unresolved": true, "key": {