openstack
/
octavia-tempest-plugin
Code Issues Proposed changes

Update patch set 3 

Patch Set 3: Code-Review-1

(3 comments)

Patch-set: 3
Reviewer: Gerrit User 34429 <34429@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, 97d337547aa3f7cb17b701764836ed823a3e725b
Attention: {"person_ident":"Gerrit User 9816 \u003c9816@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_34429\u003e replied on the change"}
This commit is contained in:
Gerrit User 34429 2024-04-16 06:52:49 +00:00 committed by Gerrit Code Review
parent 0af36e3aaa
commit 8e46d8e85d
1 changed files with 63 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

63
5a4cad57773d83a00f21df94dfed43d5e4bbcc58
View File

@ -16,6 +16,69 @@
"message": "recheck this change does not affect code logic.",
"revId": "5a4cad57773d83a00f21df94dfed43d5e4bbcc58",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "fd6724ed_78ba1265",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 3
},
"lineNbr": 0,
"author": {
"id": 34429
},
"writtenOn": "2024-04-16T06:52:49Z",
"side": 1,
"message": "I know my comments are not about changes in this patch, but could you fix it anyway please?",
"revId": "5a4cad57773d83a00f21df94dfed43d5e4bbcc58",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "3b41208f_cc73ecfd",
"filename": "zuul.d/jobs.yaml",
"patchSetId": 3
},
"lineNbr": 670,
"author": {
"id": 34429
},
"writtenOn": "2024-04-16T06:52:49Z",
"side": 1,
"message": "shouldn\u0027t that be 2023.2 actually?",
"range": {
"startLine": 670,
"startChar": 30,
"endLine": 670,
"endChar": 36
},
"revId": "5a4cad57773d83a00f21df94dfed43d5e4bbcc58",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "3c7cba78_866171d2",
"filename": "zuul.d/jobs.yaml",
"patchSetId": 3
},
"lineNbr": 898,
"author": {
"id": 34429
},
"writtenOn": "2024-04-16T06:52:49Z",
"side": 1,
"message": "Same here, 2023.2.",
"range": {
"startLine": 898,
"startChar": 30,
"endLine": 898,
"endChar": 36
},
"revId": "5a4cad57773d83a00f21df94dfed43d5e4bbcc58",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}