openstack
/
octavia-tempest-plugin
Code Issues Proposed changes

Update patch set 4 

Patch Set 4: Code-Review-1

(1 comment)

Patch-set: 4
Label: Code-Review=-1
This commit is contained in:
Gerrit User 11628 2019-01-08 01:43:52 +00:00 committed by Gerrit Code Review
parent ccc0adeb55
commit 9e45e389a9
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
444dde719c3ad1950c035d4b48f14007adf066ed Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"key": {
"uuid": "dfd5e7cf_6df8f9c3",
"filename": "octavia_tempest_plugin/tests/api/v2/test_member.py",
"patchSetId": 4
},
"lineNbr": 106,
"author": {
"id": 11628
},
"writtenOn": "2019-01-08T01:43:52Z",
"side": 1,
"message": "I don\u0027t like this because it could lead to false positives.\nThis is why we are explicit with the feature disable flags in the configuration file.\nHow do we know that it\u0027s not really a failure when using the monitor_address and/or monitor_port or some other reason?\nI think any \"disabled\" features should be explicitly based on settings disabled in the configuration file.",
"revId": "444dde719c3ad1950c035d4b48f14007adf066ed",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}