Browse Source

Fix dependency on requests library version

The code was calling property Response.next which is only available in
requests >= 2.15.0 [1]. At present minimum version of requests library
is 2.14.2 in requirements.txt. Instead of bumping its version (impacts
packaging specially to already released OpenStack versions), we can
solve it on our side with this patch.

The error was:
    AttributeError: 'Response' object has no attribute 'next'
    
[1] https://github.com/requests/requests/blob/v2.15.0/HISTORY.rst

Story: 2004641
Task: 28591

Change-Id: I15b496c740b0c7c8970501d08497ba43cbffda2b
tags/1.0.0
Carlos Goncalves 9 months ago
parent
commit
c451ff963f
1 changed files with 4 additions and 1 deletions
  1. 4
    1
      octavia_tempest_plugin/tests/test_base.py

+ 4
- 1
octavia_tempest_plugin/tests/test_base.py View File

@@ -774,6 +774,8 @@ class LoadBalancerBaseTestWithCompute(LoadBalancerBaseTest):
774 774
         :param cookies: Optional cookies to send in the request.
775 775
         :param redirect: Is the request a redirect? If true, assume the passed
776 776
                          content should be the next URL in the chain.
777
+        :param timeout: Optional seconds to wait for the server to send data.
778
+
777 779
         :return: boolean success status
778 780
 
779 781
         :raises: testtools.matchers.MismatchError
@@ -788,6 +790,7 @@ class LoadBalancerBaseTestWithCompute(LoadBalancerBaseTest):
788 790
                 self.assertEqual(response_code, req.status_code)
789 791
             if redirect:
790 792
                 self.assertTrue(req.is_redirect)
791
-                self.assertEqual(response_content, req.next.url)
793
+                self.assertEqual(response_content,
794
+                                 session.get_redirect_target(req))
792 795
             elif response_content:
793 796
                 self.assertEqual(six.text_type(response_content), req.text)

Loading…
Cancel
Save