Update patch set 11
Patch Set 11: (3 comments) Patch-set: 11 Attention: {"person_ident":"Gerrit User 34429 \u003c34429@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_31664\u003e replied on the change"} Attention: {"person_ident":"Gerrit User 31664 \u003c31664@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_31664\u003e replied on the change"}
This commit is contained in:
parent
0357b06118
commit
df07282baf
|
@ -57,6 +57,30 @@
|
|||
"revId": "2ac5e8169fd1ce38998ac2e66ae6c216e0b9f584",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "7a087ac7_6ba097ce",
|
||||
"filename": "octavia_tempest_plugin/tests/api/v2/test_listener.py",
|
||||
"patchSetId": 10
|
||||
},
|
||||
"lineNbr": 64,
|
||||
"author": {
|
||||
"id": 31664
|
||||
},
|
||||
"writtenOn": "2023-10-19T12:09:32Z",
|
||||
"side": 1,
|
||||
"message": "I copied it from octavia-tempest-plugin, but I guess that as you mentioned, raw assert was probably used because it is a class method.",
|
||||
"parentUuid": "408d948a_3610ddbc",
|
||||
"range": {
|
||||
"startLine": 64,
|
||||
"startChar": 12,
|
||||
"endLine": 64,
|
||||
"endChar": 52
|
||||
},
|
||||
"revId": "2ac5e8169fd1ce38998ac2e66ae6c216e0b9f584",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
|
@ -79,6 +103,30 @@
|
|||
},
|
||||
"revId": "2ac5e8169fd1ce38998ac2e66ae6c216e0b9f584",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "5bd88407_06ba7f30",
|
||||
"filename": "octavia_tempest_plugin/tests/api/v2/test_listener.py",
|
||||
"patchSetId": 10
|
||||
},
|
||||
"lineNbr": 140,
|
||||
"author": {
|
||||
"id": 31664
|
||||
},
|
||||
"writtenOn": "2023-10-19T12:09:32Z",
|
||||
"side": 1,
|
||||
"message": "Done",
|
||||
"parentUuid": "6cd7fea5_ef64d050",
|
||||
"range": {
|
||||
"startLine": 140,
|
||||
"startChar": 8,
|
||||
"endLine": 140,
|
||||
"endChar": 30
|
||||
},
|
||||
"revId": "2ac5e8169fd1ce38998ac2e66ae6c216e0b9f584",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
|
@ -0,0 +1,21 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"unresolved": false,
|
||||
"key": {
|
||||
"uuid": "423aa855_01b72822",
|
||||
"filename": "/PATCHSET_LEVEL",
|
||||
"patchSetId": 11
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 31664
|
||||
},
|
||||
"writtenOn": "2023-10-19T12:09:32Z",
|
||||
"side": 1,
|
||||
"message": "Thanks Tom, I changed this patch according to your comments (partial) review, and I changed the Noop Cetificate Manager patch according to Michael\u0027s comments, so let\u0027s see if the check pipepline will pass here",
|
||||
"revId": "602baffcc1305ce01c14db24f03bedb568b325e2",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue