116 lines
3.7 KiB
Plaintext
116 lines
3.7 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "e82afca8_82c30a64",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 18
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 31664
|
|
},
|
|
"writtenOn": "2023-10-30T11:52:51Z",
|
|
"side": 1,
|
|
"message": "Looks good to me",
|
|
"revId": "5bc677c4beb4a626ac906440b18221dd687cdad5",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "a3e0ffee_dbc8efc8",
|
|
"filename": "octavia_tempest_plugin/tests/api/v2/test_listener.py",
|
|
"patchSetId": 18
|
|
},
|
|
"lineNbr": 956,
|
|
"author": {
|
|
"id": 31664
|
|
},
|
|
"writtenOn": "2023-10-26T14:45:46Z",
|
|
"side": 1,
|
|
"message": "if I understand it correctly, we add the fields to the show_listener_response_fields, and then we iterate all fields and make sure the listeners have the same fields.\n\nOn this patch we add the HSTS fields to the fields we check/compare, but we don\u0027t add those fields to the listener kwargs, so we basically make sure none of the listeners have the HSTS fields (?)",
|
|
"range": {
|
|
"startLine": 952,
|
|
"startChar": 8,
|
|
"endLine": 956,
|
|
"endChar": 79
|
|
},
|
|
"revId": "5bc677c4beb4a626ac906440b18221dd687cdad5",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "2efd92f0_b76a798a",
|
|
"filename": "octavia_tempest_plugin/tests/api/v2/test_listener.py",
|
|
"patchSetId": 18
|
|
},
|
|
"lineNbr": 956,
|
|
"author": {
|
|
"id": 34429
|
|
},
|
|
"writtenOn": "2023-10-30T11:30:58Z",
|
|
"side": 1,
|
|
"message": "No, the response always contains these new fields, even if they were not set during listener creation. The Listener data model always has these new field. If they are not set explicitly in the request the default values will be used.",
|
|
"parentUuid": "a3e0ffee_dbc8efc8",
|
|
"range": {
|
|
"startLine": 952,
|
|
"startChar": 8,
|
|
"endLine": 956,
|
|
"endChar": 79
|
|
},
|
|
"revId": "5bc677c4beb4a626ac906440b18221dd687cdad5",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "adc56688_7a09b277",
|
|
"filename": "octavia_tempest_plugin/tests/api/v2/test_listener.py",
|
|
"patchSetId": 18
|
|
},
|
|
"lineNbr": 956,
|
|
"author": {
|
|
"id": 31664
|
|
},
|
|
"writtenOn": "2023-10-30T11:52:43Z",
|
|
"side": 1,
|
|
"message": "ok, so that would be another thing to test - making sure those flags are not enabled by default.",
|
|
"parentUuid": "2efd92f0_b76a798a",
|
|
"range": {
|
|
"startLine": 952,
|
|
"startChar": 8,
|
|
"endLine": 956,
|
|
"endChar": 79
|
|
},
|
|
"revId": "5bc677c4beb4a626ac906440b18221dd687cdad5",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "80def8ec_11538736",
|
|
"filename": "octavia_tempest_plugin/tests/api/v2/test_listener.py",
|
|
"patchSetId": 18
|
|
},
|
|
"lineNbr": 956,
|
|
"author": {
|
|
"id": 34429
|
|
},
|
|
"writtenOn": "2023-10-30T12:08:34Z",
|
|
"side": 1,
|
|
"message": "That is done by functional tests here https://review.opendev.org/c/openstack/octavia/+/880806/38/octavia/tests/functional/api/v2/test_load_balancer.py",
|
|
"parentUuid": "adc56688_7a09b277",
|
|
"range": {
|
|
"startLine": 952,
|
|
"startChar": 8,
|
|
"endLine": 956,
|
|
"endChar": 79
|
|
},
|
|
"revId": "5bc677c4beb4a626ac906440b18221dd687cdad5",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |