102 lines
3.1 KiB
Plaintext
102 lines
3.1 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "3f79a3b5_08e32ca6",
|
|
"filename": "octavia_tempest_plugin/tests/api/v2/test_member.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 159,
|
|
"author": {
|
|
"id": 6773
|
|
},
|
|
"writtenOn": "2018-08-31T08:58:09Z",
|
|
"side": 1,
|
|
"message": "Perhaps we need to turn this piece of code in a helper method to avoid duplicating it around the whole file ? May I suggest something like:\n\n def get_member(self, member_params):\n monitor_supported \u003d False\n try:\n member \u003d \n except Exception:\n ...\n member_params.pop(..., None)\n member \u003d ...\n\n return (member, monitor_supported)",
|
|
"range": {
|
|
"startLine": 151,
|
|
"startChar": 0,
|
|
"endLine": 159,
|
|
"endChar": 74
|
|
},
|
|
"revId": "14f9f72cde9a3f53078091dd94b467110d2747c8",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "3f79a3b5_063698b5",
|
|
"filename": "octavia_tempest_plugin/tests/api/v2/test_member.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 159,
|
|
"author": {
|
|
"id": 17776
|
|
},
|
|
"writtenOn": "2018-09-06T05:18:27Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "3f79a3b5_08e32ca6",
|
|
"range": {
|
|
"startLine": 151,
|
|
"startChar": 0,
|
|
"endLine": 159,
|
|
"endChar": 74
|
|
},
|
|
"revId": "14f9f72cde9a3f53078091dd94b467110d2747c8",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "3f79a3b5_28f7085c",
|
|
"filename": "octavia_tempest_plugin/tests/api/v2/test_member.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 448,
|
|
"author": {
|
|
"id": 6773
|
|
},
|
|
"writtenOn": "2018-08-31T08:58:09Z",
|
|
"side": 1,
|
|
"message": "member, no_monitor \u003d self.get_member(...)",
|
|
"revId": "14f9f72cde9a3f53078091dd94b467110d2747c8",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "3f79a3b5_e896f0ef",
|
|
"filename": "octavia_tempest_plugin/tests/api/v2/test_member.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 549,
|
|
"author": {
|
|
"id": 6773
|
|
},
|
|
"writtenOn": "2018-08-31T08:58:09Z",
|
|
"side": 1,
|
|
"message": "member, no_monitor \u003d self.get_member(...)",
|
|
"revId": "14f9f72cde9a3f53078091dd94b467110d2747c8",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "3f79a3b5_a8a0f843",
|
|
"filename": "octavia_tempest_plugin/tests/api/v2/test_member.py",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 739,
|
|
"author": {
|
|
"id": 6773
|
|
},
|
|
"writtenOn": "2018-08-31T08:58:09Z",
|
|
"side": 1,
|
|
"message": "member1, no_monitor \u003d self.get_member(...)",
|
|
"revId": "14f9f72cde9a3f53078091dd94b467110d2747c8",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |