octavia-tempest-plugin/59482b0cfdb3ed127e1b4b0277967d78421856ed

{
  "comments": [
    {
      "key": {
        "uuid": "9f560f44_9c18d31e",
        "filename": "octavia_tempest_plugin/tests/scenario/v2/test_traffic_ops.py",
        "patchSetId": 3
      },
      "lineNbr": 37,
      "author": {
        "id": 1131
      },
      "writtenOn": "2020-10-06T14:24:40Z",
      "side": 1,
      "message": "Name of test in comment is wrong, and why does this need to be defined in the class?  Can\u0027t we just use 104 below?",
      "revId": "59482b0cfdb3ed127e1b4b0277967d78421856ed",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "9f560f44_e7105cae",
        "filename": "octavia_tempest_plugin/tests/scenario/v2/test_traffic_ops.py",
        "patchSetId": 3
      },
      "lineNbr": 37,
      "author": {
        "id": 28609
      },
      "writtenOn": "2020-10-06T15:06:06Z",
      "side": 1,
      "message": "1) Agree, I\u0027ll fix this comment.\n2) According Michael having this port as class attribute should improve time execution.\n\n### Note ###\nI\u0027ve also pushed a patch to improve our current procedure of \"maintaining tests\u0027 ports\"\nI\u0027m talking about: https://review.opendev.org/#/c/755436/ and I must say that I\u0027ll be more than happy to have the above patch merged before all other patches I\u0027m working on, including this one.\nSo once it will happen I\u0027ll simply add \"test_port \u003d self.pool_of_ports[\u0027http_range\u0027].pop(0)\" instead of \"udp_port_104 \u003d 104\"",
      "parentUuid": "9f560f44_9c18d31e",
      "revId": "59482b0cfdb3ed127e1b4b0277967d78421856ed",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "9f560f44_fc0e2fe2",
        "filename": "octavia_tempest_plugin/tests/scenario/v2/test_traffic_ops.py",
        "patchSetId": 3
      },
      "lineNbr": 102,
      "author": {
        "id": 1131
      },
      "writtenOn": "2020-10-06T14:24:40Z",
      "side": 1,
      "message": "Was this failing pep8?  Would just leave alone otherwise",
      "revId": "59482b0cfdb3ed127e1b4b0277967d78421856ed",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "9f560f44_07d110cd",
        "filename": "octavia_tempest_plugin/tests/scenario/v2/test_traffic_ops.py",
        "patchSetId": 3
      },
      "lineNbr": 102,
      "author": {
        "id": 28609
      },
      "writtenOn": "2020-10-06T15:06:06Z",
      "side": 1,
      "message": "Pep8 gates PASS and locally \"tox -e pep8\" did work for me.",
      "parentUuid": "9f560f44_fc0e2fe2",
      "revId": "59482b0cfdb3ed127e1b4b0277967d78421856ed",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "9f560f44_bca037a6",
        "filename": "octavia_tempest_plugin/tests/scenario/v2/test_traffic_ops.py",
        "patchSetId": 3
      },
      "lineNbr": 148,
      "author": {
        "id": 1131
      },
      "writtenOn": "2020-10-06T14:24:40Z",
      "side": 1,
      "message": "nit: don\u0027t need else as return above is end of that block.  It will eventually cause a pylint error when the version moves forward, something we\u0027ve had to fix in other repos.",
      "revId": "59482b0cfdb3ed127e1b4b0277967d78421856ed",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "9f560f44_4780289d",
        "filename": "octavia_tempest_plugin/tests/scenario/v2/test_traffic_ops.py",
        "patchSetId": 3
      },
      "lineNbr": 148,
      "author": {
        "id": 28609
      },
      "writtenOn": "2020-10-06T15:06:06Z",
      "side": 1,
      "message": "Maybe I can simply replace \"else\" with \"if create_healtmonitor is True\" then?",
      "parentUuid": "9f560f44_bca037a6",
      "revId": "59482b0cfdb3ed127e1b4b0277967d78421856ed",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "9f560f44_fcb74f84",
        "filename": "octavia_tempest_plugin/tests/scenario/v2/test_traffic_ops.py",
        "patchSetId": 3
      },
      "lineNbr": 152,
      "author": {
        "id": 1131
      },
      "writtenOn": "2020-10-06T14:24:40Z",
      "side": 1,
      "message": "nit: other occurrences of calls to create_healthmonitor() use a dict when calling, I think to make sure the correct constant strings are used.",
      "revId": "59482b0cfdb3ed127e1b4b0277967d78421856ed",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "9f560f44_bc05d77b",
        "filename": "octavia_tempest_plugin/tests/scenario/v2/test_traffic_ops.py",
        "patchSetId": 3
      },
      "lineNbr": 235,
      "author": {
        "id": 1131
      },
      "writtenOn": "2020-10-06T14:24:40Z",
      "side": 1,
      "message": "Can this just be \u0027return\u0027, then we don\u0027t need \u0027success\u0027 at all since we\u0027d only get to L238 on failure",
      "revId": "59482b0cfdb3ed127e1b4b0277967d78421856ed",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "9f560f44_420ad61d",
        "filename": "octavia_tempest_plugin/tests/scenario/v2/test_traffic_ops.py",
        "patchSetId": 3
      },
      "lineNbr": 235,
      "author": {
        "id": 28609
      },
      "writtenOn": "2020-10-06T15:06:06Z",
      "side": 1,
      "message": "Maybe I can simply break the loop using \"break\" so once in some retry \"make_udp_request\" PASS it will break the loop.\nAgree we don\u0027t need \"success\" at all.",
      "parentUuid": "9f560f44_bc05d77b",
      "revId": "59482b0cfdb3ed127e1b4b0277967d78421856ed",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    },
    {
      "key": {
        "uuid": "9f560f44_875b6020",
        "filename": "octavia_tempest_plugin/tests/scenario/v2/test_traffic_ops.py",
        "patchSetId": 3
      },
      "lineNbr": 1386,
      "author": {
        "id": 1131
      },
      "writtenOn": "2020-10-06T14:24:40Z",
      "side": 1,
      "message": "I had to go find the create call above to make sure delay value was different, maybe you can just use healthmonitor[const.DELAY] + 1 ... oh, but we don\u0027t have the dict :(",
      "revId": "59482b0cfdb3ed127e1b4b0277967d78421856ed",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
      "unresolved": false
    }
  ]
}