86f6c5d420
Patch Set 4: (3 comments) Patch-set: 4 Attention: {"person_ident":"Gerrit User 31664 \u003c31664@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_31664\u003e replied on the change"}
98 lines
2.7 KiB
Plaintext
98 lines
2.7 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "f71380e2_6d2b9fc4",
|
|
"filename": "octavia_tempest_plugin/tests/api/v2/test_listener.py",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 146,
|
|
"author": {
|
|
"id": 29244
|
|
},
|
|
"writtenOn": "2023-08-31T10:39:22Z",
|
|
"side": 1,
|
|
"message": "this expression can be simplified.\nit \u0027s the same as:\n```\n return (CONF.load_balancer.test_with_noop or\n getattr(CONF.service_available, \u0027barbican\u0027, False))\n```",
|
|
"range": {
|
|
"startLine": 143,
|
|
"startChar": 8,
|
|
"endLine": 146,
|
|
"endChar": 0
|
|
},
|
|
"revId": "0660229fa26b10888b44182ea57a183e3cc711f7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "20badd21_1d344cbc",
|
|
"filename": "octavia_tempest_plugin/tests/api/v2/test_listener.py",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 146,
|
|
"author": {
|
|
"id": 31664
|
|
},
|
|
"writtenOn": "2023-08-31T12:27:03Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "f71380e2_6d2b9fc4",
|
|
"range": {
|
|
"startLine": 143,
|
|
"startChar": 8,
|
|
"endLine": 146,
|
|
"endChar": 0
|
|
},
|
|
"revId": "0660229fa26b10888b44182ea57a183e3cc711f7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "51a45fe1_80cbdd3b",
|
|
"filename": "octavia_tempest_plugin/tests/api/v2/test_listener.py",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 152,
|
|
"author": {
|
|
"id": 29244
|
|
},
|
|
"writtenOn": "2023-08-31T10:39:22Z",
|
|
"side": 1,
|
|
"message": "we need real certificates only if barbican is used.\nin case of noop, we can generate random IDs to simulate barbican refs",
|
|
"range": {
|
|
"startLine": 152,
|
|
"startChar": 15,
|
|
"endLine": 152,
|
|
"endChar": 37
|
|
},
|
|
"revId": "0660229fa26b10888b44182ea57a183e3cc711f7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "fb2b4d4e_55d06b20",
|
|
"filename": "octavia_tempest_plugin/tests/api/v2/test_listener.py",
|
|
"patchSetId": 3
|
|
},
|
|
"lineNbr": 152,
|
|
"author": {
|
|
"id": 31664
|
|
},
|
|
"writtenOn": "2023-08-31T12:27:03Z",
|
|
"side": 1,
|
|
"message": "Done",
|
|
"parentUuid": "51a45fe1_80cbdd3b",
|
|
"range": {
|
|
"startLine": 152,
|
|
"startChar": 15,
|
|
"endLine": 152,
|
|
"endChar": 37
|
|
},
|
|
"revId": "0660229fa26b10888b44182ea57a183e3cc711f7",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |