octavia-tempest-plugin/2ac5e8169fd1ce38998ac2e66ae6c216e0b9f584

{
  "comments": [
    {
      "unresolved": false,
      "key": {
        "uuid": "80352e2c_2f101e02",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 10
      },
      "lineNbr": 0,
      "author": {
        "id": 34429
      },
      "writtenOn": "2023-10-11T17:10:44Z",
      "side": 1,
      "message": "I didn\u0027t fully review it yet.",
      "revId": "2ac5e8169fd1ce38998ac2e66ae6c216e0b9f584",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "e12629d3_5b7c75d7",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 10
      },
      "lineNbr": 0,
      "author": {
        "id": 34429
      },
      "writtenOn": "2023-10-14T20:27:17Z",
      "side": 1,
      "message": "Note the failing neutron-ovn-provider test, their failure seems to be related to this new test and I guess it should be fixed.",
      "revId": "2ac5e8169fd1ce38998ac2e66ae6c216e0b9f584",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "53973e24_9a0ab3ba",
        "filename": "/PATCHSET_LEVEL",
        "patchSetId": 10
      },
      "lineNbr": 0,
      "author": {
        "id": 34429
      },
      "writtenOn": "2023-10-24T15:54:18Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "e12629d3_5b7c75d7",
      "revId": "2ac5e8169fd1ce38998ac2e66ae6c216e0b9f584",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "408d948a_3610ddbc",
        "filename": "octavia_tempest_plugin/tests/api/v2/test_listener.py",
        "patchSetId": 10
      },
      "lineNbr": 64,
      "author": {
        "id": 34429
      },
      "writtenOn": "2023-10-11T17:10:44Z",
      "side": 1,
      "message": "I assume you need to use `assert` because this is a classmethod? Personally, I would always use raw `assert`s. I don\u0027t understand how `self.assertEqual(1, len(user_list[\u0027users\u0027]), msg)` is any better than this. That\u0027s just my two cents.",
      "range": {
        "startLine": 64,
        "startChar": 12,
        "endLine": 64,
        "endChar": 52
      },
      "revId": "2ac5e8169fd1ce38998ac2e66ae6c216e0b9f584",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "7a087ac7_6ba097ce",
        "filename": "octavia_tempest_plugin/tests/api/v2/test_listener.py",
        "patchSetId": 10
      },
      "lineNbr": 64,
      "author": {
        "id": 31664
      },
      "writtenOn": "2023-10-19T12:09:32Z",
      "side": 1,
      "message": "I copied it from octavia-tempest-plugin, but I guess that as you mentioned, raw assert was probably used because it is a class method.",
      "parentUuid": "408d948a_3610ddbc",
      "range": {
        "startLine": 64,
        "startChar": 12,
        "endLine": 64,
        "endChar": 52
      },
      "revId": "2ac5e8169fd1ce38998ac2e66ae6c216e0b9f584",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "2e2180c3_0aa02645",
        "filename": "octavia_tempest_plugin/tests/api/v2/test_listener.py",
        "patchSetId": 10
      },
      "lineNbr": 64,
      "author": {
        "id": 11628
      },
      "writtenOn": "2023-11-06T20:58:10Z",
      "side": 1,
      "message": "Using raw assert means the test runner cannot collect the test results. They should be avoided and it is probably bug if they are used elsewhere in the tests.\nhttps://docs.python.org/3/library/unittest.html#basic-example",
      "parentUuid": "7a087ac7_6ba097ce",
      "range": {
        "startLine": 64,
        "startChar": 12,
        "endLine": 64,
        "endChar": 52
      },
      "revId": "2ac5e8169fd1ce38998ac2e66ae6c216e0b9f584",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "f8dddf48_a6546e32",
        "filename": "octavia_tempest_plugin/tests/api/v2/test_listener.py",
        "patchSetId": 10
      },
      "lineNbr": 64,
      "author": {
        "id": 31664
      },
      "writtenOn": "2023-11-13T16:58:05Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "2e2180c3_0aa02645",
      "range": {
        "startLine": 64,
        "startChar": 12,
        "endLine": 64,
        "endChar": 52
      },
      "revId": "2ac5e8169fd1ce38998ac2e66ae6c216e0b9f584",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": true,
      "key": {
        "uuid": "6cd7fea5_ef64d050",
        "filename": "octavia_tempest_plugin/tests/api/v2/test_listener.py",
        "patchSetId": 10
      },
      "lineNbr": 140,
      "author": {
        "id": 34429
      },
      "writtenOn": "2023-10-11T17:10:44Z",
      "side": 1,
      "message": "It\u0027s only a style kind of thing, but I would put the verb first in the name, and since it returns a bool I\u0027d probably call it `should_apply_terminated_https` or `can_apply_terminated_https` something like that.",
      "range": {
        "startLine": 140,
        "startChar": 8,
        "endLine": 140,
        "endChar": 30
      },
      "revId": "2ac5e8169fd1ce38998ac2e66ae6c216e0b9f584",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    },
    {
      "unresolved": false,
      "key": {
        "uuid": "5bd88407_06ba7f30",
        "filename": "octavia_tempest_plugin/tests/api/v2/test_listener.py",
        "patchSetId": 10
      },
      "lineNbr": 140,
      "author": {
        "id": 31664
      },
      "writtenOn": "2023-10-19T12:09:32Z",
      "side": 1,
      "message": "Done",
      "parentUuid": "6cd7fea5_ef64d050",
      "range": {
        "startLine": 140,
        "startChar": 8,
        "endLine": 140,
        "endChar": 30
      },
      "revId": "2ac5e8169fd1ce38998ac2e66ae6c216e0b9f584",
      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
    }
  ]
}