openstack
/
octavia-tempest-plugin
Code Issues Proposed changes
octavia-tempest-plugin/ca24bc3e8d170ab9148a002dde8...

797 lines
26 KiB
Plaintext
Raw Blame History

{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "18fb6600_c9c6b343",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 11
},
"lineNbr": 0,
"author": {
"id": 28609
},
"writtenOn": "2023-10-25T16:16:08Z",
"side": 1,
"message": "Hi Lukas!\nThere is a need to work on this patch a bit more and to fix some stuff.\nNote: I didn\u0027t review the tests part yet, will do so soon.\nThanks!",
"revId": "ca24bc3e8d170ab9148a002dde8bdd1e3754249e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "a4345089_9011d23c",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 11
},
"lineNbr": 0,
"author": {
"id": 28609
},
"writtenOn": "2023-10-26T14:23:32Z",
"side": 1,
"message": "Can we reduce the number of servers and to have: 1, 2 as default and 3 as backup?\nI think that 3 servers is enough for most of the cases, it will also simplify the code and reduce tests\u0027 execution time.",
"revId": "ca24bc3e8d170ab9148a002dde8bdd1e3754249e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "4aeee4e7_54e47a5c",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 11
},
"lineNbr": 0,
"author": {
"id": 30674
},
"writtenOn": "2023-11-06T12:01:13Z",
"side": 1,
"message": "Thank you! I updated the patch and I added comments when I felt like a change was not needed.",
"parentUuid": "18fb6600_c9c6b343",
"revId": "ca24bc3e8d170ab9148a002dde8bdd1e3754249e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "fb6ad159_ed8862d7",
"filename": "octavia_tempest_plugin/tests/scenario/v2/test_backup_members.py",
"patchSetId": 11
},
"lineNbr": 186,
"author": {
"id": 28609
},
"writtenOn": "2023-10-25T16:16:08Z",
"side": 1,
"message": "We probably need a cleanup here, I mean:\ncls.addClassResourceCleanup(cls.mem_member_client.cleanup_member,....\nRelevant for all the rest:1,2,3 and 4",
"revId": "ca24bc3e8d170ab9148a002dde8bdd1e3754249e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ac46b85b_f6e9d348",
"filename": "octavia_tempest_plugin/tests/scenario/v2/test_backup_members.py",
"patchSetId": 11
},
"lineNbr": 186,
"author": {
"id": 30674
},
"writtenOn": "2023-11-06T12:01:13Z",
"side": 1,
"message": "We probably do not need to add cleanup here because we use cascade\u003dTrue option in the cleanup_loadbalancer function (https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/897564/11/octavia_tempest_plugin/tests/scenario/v2/test_backup_members.py#56)",
"parentUuid": "fb6ad159_ed8862d7",
"revId": "ca24bc3e8d170ab9148a002dde8bdd1e3754249e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "2cfa950f_6ca2b250",
"filename": "octavia_tempest_plugin/tests/scenario/v2/test_backup_members.py",
"patchSetId": 11
},
"lineNbr": 186,
"author": {
"id": 28609
},
"writtenOn": "2023-11-28T14:13:50Z",
"side": 1,
"message": "Done",
"parentUuid": "ac46b85b_f6e9d348",
"revId": "ca24bc3e8d170ab9148a002dde8bdd1e3754249e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "c17f2897_a003094b",
"filename": "octavia_tempest_plugin/tests/scenario/v2/test_backup_members.py",
"patchSetId": 11
},
"lineNbr": 274,
"author": {
"id": 28609
},
"writtenOn": "2023-10-25T16:16:08Z",
"side": 1,
"message": "Missing cleanup for \"hm\" created?",
"revId": "ca24bc3e8d170ab9148a002dde8bdd1e3754249e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "16136c41_0ba8b71f",
"filename": "octavia_tempest_plugin/tests/scenario/v2/test_backup_members.py",
"patchSetId": 11
},
"lineNbr": 274,
"author": {
"id": 30674
},
"writtenOn": "2023-11-06T12:01:13Z",
"side": 1,
"message": "We probably do not need to add cleanup here because we use cascade\u003dTrue option in the cleanup_loadbalancer function (https://review.opendev.org/c/openstack/octavia-tempest-plugin/+/897564/11/octavia_tempest_plugin/tests/scenario/v2/test_backup_members.py#56)",
"parentUuid": "c17f2897_a003094b",
"revId": "ca24bc3e8d170ab9148a002dde8bdd1e3754249e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "e420990f_48391de3",
"filename": "octavia_tempest_plugin/tests/scenario/v2/test_backup_members.py",
"patchSetId": 11
},
"lineNbr": 274,
"author": {
"id": 28609
},
"writtenOn": "2023-11-28T14:13:50Z",
"side": 1,
"message": "Done",
"parentUuid": "16136c41_0ba8b71f",
"revId": "ca24bc3e8d170ab9148a002dde8bdd1e3754249e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "066f3d56_102bd919",
"filename": "octavia_tempest_plugin/tests/scenario/v2/test_backup_members.py",
"patchSetId": 11
},
"lineNbr": 275,
"author": {
"id": 28609
},
"writtenOn": "2023-10-25T16:16:08Z",
"side": 1,
"message": "There is a concept to name helper function like this to start with underscore, it means: _check_member_status",
"range": {
"startLine": 275,
"startChar": 8,
"endLine": 275,
"endChar": 27
},
"revId": "ca24bc3e8d170ab9148a002dde8bdd1e3754249e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "2c2612cf_04782557",
"filename": "octavia_tempest_plugin/tests/scenario/v2/test_backup_members.py",
"patchSetId": 11
},
"lineNbr": 275,
"author": {
"id": 30674
},
"writtenOn": "2023-11-06T12:01:13Z",
"side": 1,
"message": "Done:).",
"parentUuid": "066f3d56_102bd919",
"range": {
"startLine": 275,
"startChar": 8,
"endLine": 275,
"endChar": 27
},
"revId": "ca24bc3e8d170ab9148a002dde8bdd1e3754249e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "4c038827_25c3ff0b",
"filename": "octavia_tempest_plugin/tests/scenario/v2/test_backup_members.py",
"patchSetId": 11
},
"lineNbr": 284,
"author": {
"id": 28609
},
"writtenOn": "2023-10-25T16:16:08Z",
"side": 1,
"message": "Same as in L274\n+ \nIt\u0027s about getting HTTP response from member, therefore renaming to \"_get_active_members_response\" will be more accurate I think.",
"range": {
"startLine": 284,
"startChar": 8,
"endLine": 284,
"endChar": 26
},
"revId": "ca24bc3e8d170ab9148a002dde8bdd1e3754249e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "bfd9fa60_e8634cd4",
"filename": "octavia_tempest_plugin/tests/scenario/v2/test_backup_members.py",
"patchSetId": 11
},
"lineNbr": 284,
"author": {
"id": 30674
},
"writtenOn": "2023-11-06T12:01:13Z",
"side": 1,
"message": "Done:)",
"parentUuid": "4c038827_25c3ff0b",
"range": {
"startLine": 284,
"startChar": 8,
"endLine": 284,
"endChar": 26
},
"revId": "ca24bc3e8d170ab9148a002dde8bdd1e3754249e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "fd1ae090_13e3c80f",
"filename": "octavia_tempest_plugin/tests/scenario/v2/test_backup_members.py",
"patchSetId": 11
},
"lineNbr": 286,
"author": {
"id": 28609
},
"writtenOn": "2023-10-25T16:16:08Z",
"side": 1,
"message": "I think that we need to include a port to create this URL here, to make it work always. Means that the URL needs to have a port taken from listener_kwargs L82.\nFor example, if someone will change listener port from 80 to 85 this L85 this URL won\u0027t be valid anymore as it assumes that the default 80 is used.",
"range": {
"startLine": 286,
"startChar": 0,
"endLine": 286,
"endChar": 45
},
"revId": "ca24bc3e8d170ab9148a002dde8bdd1e3754249e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "251a0737_0b3f94fe",
"filename": "octavia_tempest_plugin/tests/scenario/v2/test_backup_members.py",
"patchSetId": 11
},
"lineNbr": 286,
"author": {
"id": 30674
},
"writtenOn": "2023-11-06T12:01:13Z",
"side": 1,
"message": "Done",
"parentUuid": "fd1ae090_13e3c80f",
"range": {
"startLine": 286,
"startChar": 0,
"endLine": 286,
"endChar": 45
},
"revId": "ca24bc3e8d170ab9148a002dde8bdd1e3754249e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "08b51e29_9e098987",
"filename": "octavia_tempest_plugin/tests/scenario/v2/test_backup_members.py",
"patchSetId": 11
},
"lineNbr": 303,
"author": {
"id": 28609
},
"writtenOn": "2023-10-26T14:23:32Z",
"side": 1,
"message": "1) This test creates nothing, I mean no backup member is actually created within this code. Backup member(4) was created in L2448.\nHere we check the \"initial state\" of the stuff that have been created in resource setup: 1,2,3 are in loop and 4 is not.\nI would expect the \"test_create_backup_member\" logic to be something like:\n1) Create backup member, wait till ACTIVE\n2) Ensure that the \"backup\u0027 flag is actually set to False (using show_member)\n3) Check that no traffic is received from this member (as it\u0027s backup) when you send HTTP GETs to LB. (something you\u0027ve done in L297)\n\n2) I\u0027m personally prefer to use \"msg\" in all the assertions that supports this option, for example this one does:\nassertIn(member, container, msg\u003dNone)\nThese messages are really helpful when test fails and for debugging as well.",
"range": {
"startLine": 298,
"startChar": 0,
"endLine": 303,
"endChar": 69
},
"revId": "ca24bc3e8d170ab9148a002dde8bdd1e3754249e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "32bd3f76_91dc4121",
"filename": "octavia_tempest_plugin/tests/scenario/v2/test_backup_members.py",
"patchSetId": 11
},
"lineNbr": 303,
"author": {
"id": 30674
},
"writtenOn": "2023-11-06T12:01:13Z",
"side": 1,
"message": "Maybe I could rename the test? I think it is useful to have it. It is simple smoke test. I added the show_member() to check whether the members have to correct flags.\n\nI\u0027m not sure whether it is good idea to create a new backup member inside the test: 1) it takes a lot of time and 2) I\u0027m not sure what would be the added value of this as the resources are created in the resource_setup -- the creation has been tested in some way, in the test we just check whether the backup member was created successfully. But if you think that I should add it here I will do so:).",
"parentUuid": "08b51e29_9e098987",
"range": {
"startLine": 298,
"startChar": 0,
"endLine": 303,
"endChar": 69
},
"revId": "ca24bc3e8d170ab9148a002dde8bdd1e3754249e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "ce0ce7f5_a3ef02e8",
"filename": "octavia_tempest_plugin/tests/scenario/v2/test_backup_members.py",
"patchSetId": 11
},
"lineNbr": 303,
"author": {
"id": 30674
},
"writtenOn": "2023-12-19T12:44:07Z",
"side": 1,
"message": "I think we can close this thread:). We have the API tests now and the scenario test we talk about here is probably a good smoke test. We can open it again if someone disagrees.",
"parentUuid": "32bd3f76_91dc4121",
"range": {
"startLine": 298,
"startChar": 0,
"endLine": 303,
"endChar": 69
},
"revId": "ca24bc3e8d170ab9148a002dde8bdd1e3754249e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "1b1fbf0a_2de9f596",
"filename": "octavia_tempest_plugin/tests/scenario/v2/test_backup_members.py",
"patchSetId": 11
},
"lineNbr": 310,
"author": {
"id": 28609
},
"writtenOn": "2023-10-26T14:23:32Z",
"side": 1,
"message": "I think that it\u0027s worth to include \"backup\" flag here (like in L413), it means: if active then \"backup:False\" and to validate that it still set properly.\nPerhaps some member have decided to become \"backup\" after unpause or something.",
"range": {
"startLine": 307,
"startChar": 0,
"endLine": 310,
"endChar": 17
},
"revId": "ca24bc3e8d170ab9148a002dde8bdd1e3754249e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "b36899e6_286933ec",
"filename": "octavia_tempest_plugin/tests/scenario/v2/test_backup_members.py",
"patchSetId": 11
},
"lineNbr": 310,
"author": {
"id": 30674
},
"writtenOn": "2023-11-06T12:01:13Z",
"side": 1,
"message": "Done:)",
"parentUuid": "1b1fbf0a_2de9f596",
"range": {
"startLine": 307,
"startChar": 0,
"endLine": 310,
"endChar": 17
},
"revId": "ca24bc3e8d170ab9148a002dde8bdd1e3754249e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "d11b576f_075b8ea1",
"filename": "octavia_tempest_plugin/tests/scenario/v2/test_backup_members.py",
"patchSetId": 11
},
"lineNbr": 317,
"author": {
"id": 28609
},
"writtenOn": "2023-10-25T16:16:08Z",
"side": 1,
"message": "Nit\nConsider adding \"PAUSED\" to constants.",
"range": {
"startLine": 317,
"startChar": 42,
"endLine": 317,
"endChar": 48
},
"revId": "ca24bc3e8d170ab9148a002dde8bdd1e3754249e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "f4fdde1b_879c5677",
"filename": "octavia_tempest_plugin/tests/scenario/v2/test_backup_members.py",
"patchSetId": 11
},
"lineNbr": 317,
"author": {
"id": 30674
},
"writtenOn": "2023-11-06T12:01:13Z",
"side": 1,
"message": "Done:)",
"parentUuid": "d11b576f_075b8ea1",
"range": {
"startLine": 317,
"startChar": 42,
"endLine": 317,
"endChar": 48
},
"revId": "ca24bc3e8d170ab9148a002dde8bdd1e3754249e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "33738465_14df6f92",
"filename": "octavia_tempest_plugin/tests/scenario/v2/test_backup_members.py",
"patchSetId": 11
},
"lineNbr": 333,
"author": {
"id": 28609
},
"writtenOn": "2023-10-26T14:23:32Z",
"side": 1,
"message": "3?",
"revId": "ca24bc3e8d170ab9148a002dde8bdd1e3754249e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "64d21151_68092010",
"filename": "octavia_tempest_plugin/tests/scenario/v2/test_backup_members.py",
"patchSetId": 11
},
"lineNbr": 333,
"author": {
"id": 30674
},
"writtenOn": "2023-11-06T12:01:13Z",
"side": 1,
"message": "Done:)",
"parentUuid": "33738465_14df6f92",
"revId": "ca24bc3e8d170ab9148a002dde8bdd1e3754249e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "05edf8bb_98d165f8",
"filename": "octavia_tempest_plugin/tests/scenario/v2/test_backup_members.py",
"patchSetId": 11
},
"lineNbr": 359,
"author": {
"id": 28609
},
"writtenOn": "2023-10-25T16:16:08Z",
"side": 1,
"message": "You can use already existing \"ACTIVE\" from constants.",
"range": {
"startLine": 359,
"startChar": 42,
"endLine": 359,
"endChar": 48
},
"revId": "ca24bc3e8d170ab9148a002dde8bdd1e3754249e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "69a77231_5f509755",
"filename": "octavia_tempest_plugin/tests/scenario/v2/test_backup_members.py",
"patchSetId": 11
},
"lineNbr": 359,
"author": {
"id": 30674
},
"writtenOn": "2023-11-06T12:01:13Z",
"side": 1,
"message": "Done:)",
"parentUuid": "05edf8bb_98d165f8",
"range": {
"startLine": 359,
"startChar": 42,
"endLine": 359,
"endChar": 48
},
"revId": "ca24bc3e8d170ab9148a002dde8bdd1e3754249e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "26d18114_5a2e5471",
"filename": "octavia_tempest_plugin/tests/scenario/v2/test_backup_members.py",
"patchSetId": 11
},
"lineNbr": 360,
"author": {
"id": 28609
},
"writtenOn": "2023-10-25T16:16:08Z",
"side": 1,
"message": "The default timeout is set to 60, but I think that in terms of these kind of tests (backup should happen as fast as possible) we have to reduce it, maybe 10 sec?\nI\u0027d suggest asking Dev for proper timeout value to be used here.",
"range": {
"startLine": 360,
"startChar": 16,
"endLine": 360,
"endChar": 31
},
"revId": "ca24bc3e8d170ab9148a002dde8bdd1e3754249e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "1d995b7b_a979606a",
"filename": "octavia_tempest_plugin/tests/scenario/v2/test_backup_members.py",
"patchSetId": 11
},
"lineNbr": 360,
"author": {
"id": 30674
},
"writtenOn": "2023-11-06T12:01:13Z",
"side": 1,
"message": "If I remember correctly I encountered once an issue when the timeout was shorter than 60 seconds. But I would not put my hand into fire for that. It was in the early stages of writing this test so it might have been caused by something else. I\u0027ll ask someone from the dev:).",
"parentUuid": "26d18114_5a2e5471",
"range": {
"startLine": 360,
"startChar": 16,
"endLine": 360,
"endChar": 31
},
"revId": "ca24bc3e8d170ab9148a002dde8bdd1e3754249e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "4cbc9774_86e1324b",
"filename": "octavia_tempest_plugin/tests/scenario/v2/test_backup_members.py",
"patchSetId": 11
},
"lineNbr": 397,
"author": {
"id": 28609
},
"writtenOn": "2023-10-26T14:23:32Z",
"side": 1,
"message": "Nit\nThis comment: \"# Unpause webserver3\" is missing, it helps to read the code.",
"revId": "ca24bc3e8d170ab9148a002dde8bdd1e3754249e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "1fa66d7c_a7f117a4",
"filename": "octavia_tempest_plugin/tests/scenario/v2/test_backup_members.py",
"patchSetId": 11
},
"lineNbr": 397,
"author": {
"id": 30674
},
"writtenOn": "2023-11-06T12:01:13Z",
"side": 1,
"message": "Done:)",
"parentUuid": "4cbc9774_86e1324b",
"revId": "ca24bc3e8d170ab9148a002dde8bdd1e3754249e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "5fa53ad0_f645f534",
"filename": "octavia_tempest_plugin/tests/scenario/v2/test_backup_members.py",
"patchSetId": 11
},
"lineNbr": 449,
"author": {
"id": 28609
},
"writtenOn": "2023-10-26T14:23:32Z",
"side": 1,
"message": "I\u0027m not sure that \"addCleanup\" is in place here, you just have to wait and set what is needed without adding to cleanup.\nCleanup are used to delete resources created on teardown.",
"range": {
"startLine": 440,
"startChar": 0,
"endLine": 449,
"endChar": 36
},
"revId": "ca24bc3e8d170ab9148a002dde8bdd1e3754249e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "2b6ae8dd_ff3d1d64",
"filename": "octavia_tempest_plugin/tests/scenario/v2/test_backup_members.py",
"patchSetId": 11
},
"lineNbr": 449,
"author": {
"id": 30674
},
"writtenOn": "2023-11-06T12:01:13Z",
"side": 1,
"message": "Done",
"parentUuid": "5fa53ad0_f645f534",
"range": {
"startLine": 440,
"startChar": 0,
"endLine": 449,
"endChar": 36
},
"revId": "ca24bc3e8d170ab9148a002dde8bdd1e3754249e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "66c39da6_949789d8",
"filename": "octavia_tempest_plugin/tests/scenario/v2/test_backup_members.py",
"patchSetId": 11
},
"lineNbr": 555,
"author": {
"id": 28609
},
"writtenOn": "2023-10-26T14:23:32Z",
"side": 1,
"message": "Same as in L440",
"range": {
"startLine": 534,
"startChar": 0,
"endLine": 555,
"endChar": 37
},
"revId": "ca24bc3e8d170ab9148a002dde8bdd1e3754249e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "f5adb49b_1d4792c5",
"filename": "octavia_tempest_plugin/tests/scenario/v2/test_backup_members.py",
"patchSetId": 11
},
"lineNbr": 555,
"author": {
"id": 30674
},
"writtenOn": "2023-11-06T12:01:13Z",
"side": 1,
"message": "Done",
"parentUuid": "66c39da6_949789d8",
"range": {
"startLine": 534,
"startChar": 0,
"endLine": 555,
"endChar": 37
},
"revId": "ca24bc3e8d170ab9148a002dde8bdd1e3754249e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "d4616c94_cc5c9816",
"filename": "octavia_tempest_plugin/tests/scenario/v2/test_backup_members.py",
"patchSetId": 11
},
"lineNbr": 566,
"author": {
"id": 28609
},
"writtenOn": "2023-10-26T14:23:32Z",
"side": 1,
"message": "I think that such a deletion (of server4 that is used in BackupMembersTest class) may cause to problems on parallel execution. It could be that the tests in BackupMembersTest won\u0027t have server4 available.",
"range": {
"startLine": 562,
"startChar": 0,
"endLine": 566,
"endChar": 78
},
"revId": "ca24bc3e8d170ab9148a002dde8bdd1e3754249e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "38ab0c9f_3167e3b1",
"filename": "octavia_tempest_plugin/tests/scenario/v2/test_backup_members.py",
"patchSetId": 11
},
"lineNbr": 566,
"author": {
"id": 30674
},
"writtenOn": "2023-11-06T12:01:13Z",
"side": 1,
"message": "It should not cause a problem because the test is running in a separate class, thus with different resources. The BackupMembersDelete class should be executing only test_delete_backup test (I hope:).",
"parentUuid": "d4616c94_cc5c9816",
"range": {
"startLine": 562,
"startChar": 0,
"endLine": 566,
"endChar": 78
},
"revId": "ca24bc3e8d170ab9148a002dde8bdd1e3754249e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "c4adb3f8_3594a858",
"filename": "octavia_tempest_plugin/tests/scenario/v2/test_backup_members.py",
"patchSetId": 11
},
"lineNbr": 566,
"author": {
"id": 30674
},
"writtenOn": "2023-12-19T12:44:07Z",
"side": 1,
"message": "This should be resolved as well:)",
"parentUuid": "38ab0c9f_3167e3b1",
"range": {
"startLine": 562,
"startChar": 0,
"endLine": 566,
"endChar": 78
},
"revId": "ca24bc3e8d170ab9148a002dde8bdd1e3754249e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}
View Git Blame Copy Permalink