121 lines
3.3 KiB
Plaintext
121 lines
3.3 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"key": {
|
|
"uuid": "dfd5e7cf_85729610",
|
|
"filename": "octavia_tempest_plugin/tests/api/v2/test_member.py",
|
|
"patchSetId": 6
|
|
},
|
|
"lineNbr": 102,
|
|
"author": {
|
|
"id": 6469
|
|
},
|
|
"writtenOn": "2019-01-10T16:41:54Z",
|
|
"side": 1,
|
|
"message": "Make this an underscore method",
|
|
"range": {
|
|
"startLine": 102,
|
|
"startChar": 8,
|
|
"endLine": 102,
|
|
"endChar": 44
|
|
},
|
|
"revId": "0aa411e85264947833f3e68044b006fa997e61d0",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "dfd5e7cf_5438e73b",
|
|
"filename": "octavia_tempest_plugin/tests/api/v2/test_member.py",
|
|
"patchSetId": 6
|
|
},
|
|
"lineNbr": 109,
|
|
"author": {
|
|
"id": 6469
|
|
},
|
|
"writtenOn": "2019-01-10T16:41:54Z",
|
|
"side": 1,
|
|
"message": "This could be more simply written as:\n\n if not monitor:\n del member_kwargs[const.MONITOR_ADDRESS]\n del member_kwargs[const.MONITOR_PORT]\n member \u003d self.mem_member_client.create_member(**member_kwargs)",
|
|
"range": {
|
|
"startLine": 104,
|
|
"startChar": 9,
|
|
"endLine": 109,
|
|
"endChar": 74
|
|
},
|
|
"revId": "0aa411e85264947833f3e68044b006fa997e61d0",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bfdaf3ff_1a709a72",
|
|
"filename": "octavia_tempest_plugin/tests/api/v2/test_member.py",
|
|
"patchSetId": 6
|
|
},
|
|
"lineNbr": 109,
|
|
"author": {
|
|
"id": 17776
|
|
},
|
|
"writtenOn": "2019-01-21T13:14:10Z",
|
|
"side": 1,
|
|
"message": "Yeah, thats possible :)\nThanks",
|
|
"parentUuid": "dfd5e7cf_5438e73b",
|
|
"range": {
|
|
"startLine": 104,
|
|
"startChar": 9,
|
|
"endLine": 109,
|
|
"endChar": 74
|
|
},
|
|
"revId": "0aa411e85264947833f3e68044b006fa997e61d0",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "dfd5e7cf_e5ea8273",
|
|
"filename": "octavia_tempest_plugin/tests/api/v2/test_member.py",
|
|
"patchSetId": 6
|
|
},
|
|
"lineNbr": 679,
|
|
"author": {
|
|
"id": 6469
|
|
},
|
|
"writtenOn": "2019-01-10T16:41:54Z",
|
|
"side": 1,
|
|
"message": "should be member[const.MONITOR_PORT] + 1",
|
|
"range": {
|
|
"startLine": 679,
|
|
"startChar": 55,
|
|
"endLine": 679,
|
|
"endChar": 59
|
|
},
|
|
"revId": "0aa411e85264947833f3e68044b006fa997e61d0",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
},
|
|
{
|
|
"key": {
|
|
"uuid": "bfdaf3ff_9a09eade",
|
|
"filename": "octavia_tempest_plugin/tests/api/v2/test_member.py",
|
|
"patchSetId": 6
|
|
},
|
|
"lineNbr": 679,
|
|
"author": {
|
|
"id": 17776
|
|
},
|
|
"writtenOn": "2019-01-21T13:14:10Z",
|
|
"side": 1,
|
|
"message": "Seesm trivial, but Ok :)",
|
|
"parentUuid": "dfd5e7cf_e5ea8273",
|
|
"range": {
|
|
"startLine": 679,
|
|
"startChar": 55,
|
|
"endLine": 679,
|
|
"endChar": 59
|
|
},
|
|
"revId": "0aa411e85264947833f3e68044b006fa997e61d0",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
|
"unresolved": false
|
|
}
|
|
]
|
|
} |