openstack/octavia
Code Issues Proposed changes

Add warning log if auth_strategy is not keystone

Browse Source 
A user came to the IRC channel with CLI errors:
"Client-side error: Validation failure: Missing project ID in
request where one is required."

The root cause was the [api_settings] auth_strategy was set to
"noauth" instead of "keystone".

This patch adds a warning log message to the API process that
warns users that typically the auth_strategy should be set to
keystone.
It also points the user to have an administrator check the keystone
settings in the octavia.conf.

Change-Id: I7793d7a9113b23ac88e7c53d5dc292a70b9453b5
This commit is contained in:
Michael Johnson 2019-07-11 09:06:23 -07:00
parent e3aacb67ad
commit 48371c98ee
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
octavia/api/v2/controllers/load_balancer.py
View File

@ -324,7 +324,9 @@ class LoadBalancersController(base.BaseController):
if not load_balancer.project_id: if not load_balancer.project_id:
raise exceptions.ValidationException(detail=_( raise exceptions.ValidationException(detail=_(
"Missing project ID in request where one is required.")) "Missing project ID in request where one is required. "
"An administrator should check the keystone settings "
"in the Octavia configuration."))
self._auth_validate_action(context, load_balancer.project_id, self._auth_validate_action(context, load_balancer.project_id,
constants.RBAC_POST) constants.RBAC_POST)

6
octavia/cmd/api.py
View File

@ -20,6 +20,7 @@ from oslo_log import log as logging
from oslo_reports import guru_meditation_report as gmr from oslo_reports import guru_meditation_report as gmr
from octavia.api import app as api_app from octavia.api import app as api_app
from octavia.common import constants
from octavia import version from octavia import version
@ -35,6 +36,11 @@ def main():
port = cfg.CONF.api_settings.bind_port port = cfg.CONF.api_settings.bind_port
LOG.info("Starting API server on %(host)s:%(port)s", LOG.info("Starting API server on %(host)s:%(port)s",
{"host": host, "port": port}) {"host": host, "port": port})
if cfg.CONF.api_settings.auth_strategy != constants.KEYSTONE:
LOG.warning('Octavia configuration [api_settings] auth_strategy is '
'not set to "keystone". This is not a normal '
'configuration and you may get "Missing project ID" '
'errors from API calls."')
srv = simple_server.make_server(host, port, app) srv = simple_server.make_server(host, port, app)
srv.serve_forever() srv.serve_forever()