Fix uncaught DB exception when trying to get a spare amphora
The MapLoadbalancerToAmphora task performs some database queries but doesn't catch any exception from it. In case something goes wrong with the database or the query, this commit catchs any exception from the DB call, logs it and then returns None to switch to the next decider branch (boot a new amphora). Note: In Queens, string format method in the LOG.error call was changed to please pep8/pylint. Story 2007320 Task 38831 Change-Id: Ifb6c34426e0927534d332a8bbf2c66aac6c002c5 (cherry picked from commit3bbd32a2a5
) (cherry picked from commit0c1cb417e9
) (cherry picked from commit372e047a84
) (cherry picked from commite7376be7af
)
This commit is contained in:
parent
7d8472776c
commit
5528268e2f
|
@ -498,9 +498,16 @@ class MapLoadbalancerToAmphora(BaseDatabaseTask):
|
|||
"pool allocation.")
|
||||
return None
|
||||
|
||||
try:
|
||||
amp = self.amphora_repo.allocate_and_associate(
|
||||
db_apis.get_session(),
|
||||
loadbalancer_id)
|
||||
except Exception as e:
|
||||
LOG.error("Failed to get a spare amphora for "
|
||||
"loadbalancer %s due to: %s",
|
||||
loadbalancer_id, e)
|
||||
return None
|
||||
|
||||
if amp is None:
|
||||
LOG.debug("No Amphora available for load balancer with id %s",
|
||||
loadbalancer_id)
|
||||
|
|
Loading…
Reference in New Issue