openstack
/
octavia
Code Issues Proposed changes

Merge "Add warning log if auth_strategy is not keystone" into stable/stein

This commit is contained in:
Zuul 2019-09-08 17:39:42 +00:00 committed by Gerrit Code Review
parent 5d36bb6bf6 b88f104116
commit 5852b6f35c
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
octavia/api/v2/controllers/load_balancer.py
View File

@ -324,7 +324,9 @@ class LoadBalancersController(base.BaseController):
if not load_balancer.project_id: if not load_balancer.project_id:
raise exceptions.ValidationException(detail=_( raise exceptions.ValidationException(detail=_(
"Missing project ID in request where one is required.")) "Missing project ID in request where one is required. "
"An administrator should check the keystone settings "
"in the Octavia configuration."))
self._auth_validate_action(context, load_balancer.project_id, self._auth_validate_action(context, load_balancer.project_id,
constants.RBAC_POST) constants.RBAC_POST)

6
octavia/cmd/api.py
View File

@ -20,6 +20,7 @@ from oslo_log import log as logging
from oslo_reports import guru_meditation_report as gmr from oslo_reports import guru_meditation_report as gmr
from octavia.api import app as api_app from octavia.api import app as api_app
from octavia.common import constants
from octavia import version from octavia import version
@ -35,6 +36,11 @@ def main():
port = cfg.CONF.api_settings.bind_port port = cfg.CONF.api_settings.bind_port
LOG.info("Starting API server on %(host)s:%(port)s", LOG.info("Starting API server on %(host)s:%(port)s",
{"host": host, "port": port}) {"host": host, "port": port})
if cfg.CONF.api_settings.auth_strategy != constants.KEYSTONE:
LOG.warning('Octavia configuration [api_settings] auth_strategy is '
'not set to "keystone". This is not a normal '
'configuration and you may get "Missing project ID" '
'errors from API calls."')
srv = simple_server.make_server(host, port, app) srv = simple_server.make_server(host, port, app)
srv.serve_forever() srv.serve_forever()