diff --git a/octavia/amphorae/backends/utils/haproxy_query.py b/octavia/amphorae/backends/utils/haproxy_query.py index 481eff2a38..7140dea84d 100644 --- a/octavia/amphorae/backends/utils/haproxy_query.py +++ b/octavia/amphorae/backends/utils/haproxy_query.py @@ -155,6 +155,5 @@ class HAProxyQuery(object): except Exception as e: # Catch any exception - may be socket issue, or write permission # issue as well. - LOG.warning("Unable to save state: %(err)s %(output)s", - {'err': e, 'output': e.output}) + LOG.warning("Unable to save state: %r", e) return False diff --git a/octavia/tests/unit/amphorae/backends/utils/test_haproxy_query.py b/octavia/tests/unit/amphorae/backends/utils/test_haproxy_query.py index e1505f0a8c..ddb04cb391 100644 --- a/octavia/tests/unit/amphorae/backends/utils/test_haproxy_query.py +++ b/octavia/tests/unit/amphorae/backends/utils/test_haproxy_query.py @@ -159,3 +159,15 @@ class QueryTestCase(base.TestCase): self.q.save_state(filename) mock_fh.write.assert_called_once_with('DATA') + + def test_save_state_error(self): + """save_state() should swallow exceptions""" + filename = 'state_file' + + query_mock = mock.Mock(side_effect=OSError()) + self.q._query = query_mock + + try: + self.q.save_state(filename) + except Exception as ex: + self.fail("save_state() raised %r unexpectedly!" % ex)