From 47de8fa3444cc7b1b68d486ad8c06d294a9ef9de Mon Sep 17 00:00:00 2001 From: Tobias Urdin Date: Sun, 5 Mar 2023 22:16:16 +0000 Subject: [PATCH] Fix upgrade check not working The octavia-status upgrade check command fails because the initialization of Policy() requires oslo_config to be initialized already which it isn't. This can be reproduced in master by running: tox -e venv -- octavia-status upgrade check I can observe this issue multiple relases back which probably means this has been broken for a long time. We shouldn't need to init Policy() because it just loads policy rules which is not checked in upgrade check anyway. Change-Id: I16430fa52db02e7445203994220673c1037d764c --- octavia/cmd/status.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/octavia/cmd/status.py b/octavia/cmd/status.py index f98d51dad4..9e2bb7fe48 100644 --- a/octavia/cmd/status.py +++ b/octavia/cmd/status.py @@ -22,7 +22,6 @@ from stevedore import driver as stevedore_driver # Need to import to load config from octavia.common import config # noqa: F401 pylint: disable=unused-import from octavia.common import constants -from octavia.common import policy from octavia.controller.worker.v2 import taskflow_jobboard_driver as tsk_driver from octavia.i18n import _ @@ -120,7 +119,6 @@ class Checks(upgradecheck.UpgradeCommands): def main(): - policy.Policy() return upgradecheck.main( CONF, project='octavia', upgrade_command=Checks())