openstack/octavia
Code Issues Proposed changes

Fix SQLAlchemy warning about conflict relationship with Tags

Browse Source 
SQLAlchemy shows a warning about a conflict with a relationship with the
Tags object:

  SAWarning: relationship '<Obj1>._tags' will copy column <obj1>.id to
  column tags.resource_id, which conflicts with relationship(s):
  '<Obj2>._tags'

Remove this warning by using the overlaps [0] keyword in the definition
of the relationship.

[0] https://docs.sqlalchemy.org/en/20/orm/relationship_api.html#\
    sqlalchemy.orm.relationship.params.overlaps

Change-Id: I1a9a9177cafb8c52f13a646b12cff1c35afd8679
This commit is contained in:
Gregory Thiemonge 2023-02-23 11:19:38 -05:00
parent b4b6e07fe0
commit 8409c06cda
2 changed files with 19 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
octavia/db/models.py
View File

@ -234,7 +234,8 @@ class Member(base_models.BASE, base_models.IdMixin, base_models.ProjectMixin,
single_parent=True, single_parent=True,
lazy='subquery', lazy='subquery',
cascade='all,delete-orphan', cascade='all,delete-orphan',
primaryjoin='and_(foreign(Tags.resource_id)==Member.id)' primaryjoin='and_(foreign(Tags.resource_id)==Member.id)',
overlaps='_tags'
) )
def __str__(self): def __str__(self):
@ -297,7 +298,8 @@ class HealthMonitor(base_models.BASE, base_models.IdMixin,
single_parent=True, single_parent=True,
lazy='subquery', lazy='subquery',
cascade='all,delete-orphan', cascade='all,delete-orphan',
primaryjoin='and_(foreign(Tags.resource_id)==HealthMonitor.id)' primaryjoin='and_(foreign(Tags.resource_id)==HealthMonitor.id)',
overlaps='_tags'
) )
http_version = sa.Column(sa.Float, nullable=True) http_version = sa.Column(sa.Float, nullable=True)
domain_name = sa.Column(sa.String(255), nullable=True) domain_name = sa.Column(sa.String(255), nullable=True)
@ -359,7 +361,8 @@ class Pool(base_models.BASE, base_models.IdMixin, base_models.ProjectMixin,
single_parent=True, single_parent=True,
lazy='subquery', lazy='subquery',
cascade='all,delete-orphan', cascade='all,delete-orphan',
primaryjoin='and_(foreign(Tags.resource_id)==Pool.id)' primaryjoin='and_(foreign(Tags.resource_id)==Pool.id)',
overlaps='_tags'
) )
tls_certificate_id = sa.Column(sa.String(255), nullable=True) tls_certificate_id = sa.Column(sa.String(255), nullable=True)
ca_tls_certificate_id = sa.Column(sa.String(255), nullable=True) ca_tls_certificate_id = sa.Column(sa.String(255), nullable=True)
@ -439,7 +442,8 @@ class LoadBalancer(base_models.BASE, base_models.IdMixin,
single_parent=True, single_parent=True,
lazy='subquery', lazy='subquery',
cascade='all,delete-orphan', cascade='all,delete-orphan',
primaryjoin='and_(foreign(Tags.resource_id)==LoadBalancer.id)' primaryjoin='and_(foreign(Tags.resource_id)==LoadBalancer.id)',
overlaps='_tags'
) )
flavor_id = sa.Column( flavor_id = sa.Column(
sa.String(36), sa.String(36),
@ -601,7 +605,8 @@ class Listener(base_models.BASE, base_models.IdMixin,
single_parent=True, single_parent=True,
lazy='subquery', lazy='subquery',
cascade='all,delete-orphan', cascade='all,delete-orphan',
primaryjoin='and_(foreign(Tags.resource_id)==Listener.id)' primaryjoin='and_(foreign(Tags.resource_id)==Listener.id)',
overlaps='_tags'
) )
# This property should be a unique list of the default_pool and anything # This property should be a unique list of the default_pool and anything
@ -756,7 +761,8 @@ class L7Rule(base_models.BASE, base_models.IdMixin, base_models.ProjectMixin,
single_parent=True, single_parent=True,
lazy='subquery', lazy='subquery',
cascade='all,delete-orphan', cascade='all,delete-orphan',
primaryjoin='and_(foreign(Tags.resource_id)==L7Rule.id)' primaryjoin='and_(foreign(Tags.resource_id)==L7Rule.id)',
overlaps='_tags'
) )
def __str__(self): def __str__(self):
@ -821,7 +827,8 @@ class L7Policy(base_models.BASE, base_models.IdMixin, base_models.ProjectMixin,
single_parent=True, single_parent=True,
lazy='subquery', lazy='subquery',
cascade='all,delete-orphan', cascade='all,delete-orphan',
primaryjoin='and_(foreign(Tags.resource_id)==L7Policy.id)' primaryjoin='and_(foreign(Tags.resource_id)==L7Policy.id)',
overlaps='_tags'
) )
def __str__(self): def __str__(self):

5
releasenotes/notes/remove-tags-relationship-warnings-a3c0175135f6cd84.yaml Normal file
View File

@ -0,0 +1,5 @@
---
fixes:
- |
Fixed SQLAlchemy warnings about the relationship between the Tags object
and the other Octavia resources.