openstack
/
octavia
Code Issues Proposed changes

Update patch set 2 

Patch Set 2:

(1 comment)

Patch-set: 2
This commit is contained in:
Gerrit User 9816 2022-05-16 06:08:05 +00:00 committed by Gerrit Code Review
parent 944a1ac7dc
commit 8c97f1f5af
1 changed files with 20 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
7e264e1f21ee396d046e0df0c1a4f4218039e4aa
View File

@ -1,6 +1,7 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "f0262c95_4b042b30",
"filename": "octavia/common/config.py",
@ -14,8 +15,25 @@
"side": 0,
"message": "This is used only to get choices for agent_tls_protocol. For the other part constants defined in octavia.common.constants or octavia_lib.common.constants are used. I don\u0027t see any benefit of having this implementation here, TBH.",
"revId": "7e264e1f21ee396d046e0df0c1a4f4218039e4aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "946e4b65_d74c832e",
"filename": "octavia/common/config.py",
"patchSetId": 1
},
"lineNbr": 45,
"author": {
"id": 9816
},
"writtenOn": "2022-05-16T06:08:05Z",
"side": 0,
"message": "Done",
"parentUuid": "f0262c95_4b042b30",
"revId": "7e264e1f21ee396d046e0df0c1a4f4218039e4aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}