openstack
/
octavia
Code Issues Proposed changes

Update patch set 3 

Patch Set 3: Code-Review-1

(2 comments)

Patch-set: 3
Reviewer: Gerrit User 29244 <29244@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
Attention: {"person_ident":"Gerrit User 29870 \u003c29870@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Gregory Thiemonge replied on the change"}
This commit is contained in:
Gerrit User 29244 2021-10-26 09:38:47 +00:00 committed by Gerrit Code Review
parent 92379ca11e
commit d697ae26f7
1 changed files with 44 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
154e826fa8ff4fc530f34f778873dac4001099ea Normal file
View File

@ -0,0 +1,44 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "e5162d3c_9c4e0ecd",
"filename": "/COMMIT_MSG",
"patchSetId": 3
},
"lineNbr": 10,
"author": {
"id": 29244
},
"writtenOn": "2021-10-26T09:38:47Z",
"side": 1,
"message": "It seems that Octavia always sets the ingress protocol when adding SG rules. Do you have a reproducer for this issue?",
"range": {
"startLine": 10,
"startChar": 0,
"endLine": 10,
"endChar": 24
},
"revId": "154e826fa8ff4fc530f34f778873dac4001099ea",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "46e0a03b_ff715ecc",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 3
},
"lineNbr": 0,
"author": {
"id": 29244
},
"writtenOn": "2021-10-26T09:38:47Z",
"side": 1,
"message": "CR-1 to raise awareness for my question",
"revId": "154e826fa8ff4fc530f34f778873dac4001099ea",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}