2888 Commits

Author SHA1 Message Date
Michael Johnson
34edb58c12 Set the default retries down to 120
This patch changes the [haproxy_amphora] connection_max_retries and
build_active_retries default values from 300 to 120. This means load
balancer builds will wait for ten minutes instead of twenty-five minutes
for nova to boot the virtual machine.

We feel these are more reasonable default values for most production
deployments and provide a better user experience.

Only environments running in nested virtualization, without nested
virtualization enabled in the hypervisor could require a value as high as
300.

Depends-On: https://review.openstack.org/637074
Change-Id: I46be11062fb15ed21169fbec5dc8451a588273a5
2019-02-14 15:38:48 -08:00
Zuul
f026372216 Merge "Refactor the pluggin of the VIP" 2019-02-13 05:28:14 +00:00
Michael Johnson
52ffdd16a6 Add amphora agent configuration update admin API
This patch adds a new admin API that updates an amphora's agent
configuration.

Change-Id: I41ce6843fb53fa21ab84e5b1d0734e70380d716a
2019-02-11 17:30:53 -08:00
German Eichberger
06baf6d542 Refactor the pluggin of the VIP
This aims to make plugging the vip based on the amphora instead
the LB for the LB create flows.

Change-Id: I0eaae7b60333d2e720acc9570a0d398a06be46e5
2019-02-11 17:15:10 -08:00
Carlos Goncalves
5fb4683544 Install DIB binary dependencies from bindep.txt
This patch will ensure DIB binary dependencies are installed at an early
phase of deployment. As result, we prevent DIB from failing due to unmet
binary dependencies later on while building amphora images as seen in
[1].

[1] http://logs.openstack.org/81/600381/9/check/octavia-v2-dsvm-\
scenario-fedora-latest/ced40d4/controller/logs/dib-build/amphora\
-x64-haproxy.qcow2_log.txt.gz#_2019-01-18_23_15_52_244

Depends-On: https://review.openstack.org/#/c/630889
Change-Id: I6b7244b6a1398994d1c537f358086e22d1e781c1
2019-02-09 20:20:21 +00:00
Zuul
fae5b05980 Merge "Fix functional tests under Python >= 3.6" 2019-02-09 10:45:37 +00:00
Michael Johnson
0f0aa02161 Resolve amphora agent read timeout issue
Occasionally the test jobs[1] will fail with:
octavia.amphorae.drivers.haproxy.rest_api_driver [-]
Could not connect to instance. Read timed out. (read timeout=120.0)

This patch increases the default read timeout to 180 and changes the
directory copy that would subsequently fail to be more idempotent.

[1] http://logs.openstack.org/09/613709/14/check/ \
octavia-v2-dsvm-scenario-two-node/d83db12/controller2/logs/ \
screen-o-cw.txt.gz#_Feb_08_21_58_23_919928

Change-Id: Ia0bd6762c2605ce240a549b3e90e5c44b65897a5
2019-02-08 17:39:48 -08:00
Carlos Goncalves
b5dda3ce05 Fix functional tests under Python >= 3.6
Newer Python versions don't like passing a mock in to an os.path.join:

  TypeError: join() argument must be str or bytes, not 'MagicMock'

This patch also adds openstack-tox-functional-py36 to the gate queue.
Recent and major LTS distributions ship Python 3.6 or greater.

Change-Id: Ic71059da24e0d2c3f0ac3af5375906d8e8aa43f4
2019-02-09 00:32:59 +01:00
Zuul
d21c99fba9 Merge "Cleaning up logging" 2019-02-08 18:57:58 +00:00
Zuul
dd11c35180 Merge "Fix check redirect pool for creating a fully populated load balancer." 2019-02-08 15:44:50 +00:00
Zuul
04c041df26 Merge "Fix flavors support when using spares pool" 2019-02-07 19:45:22 +00:00
Vadim Ponomarev
05e16a3498 Fix check redirect pool for creating a fully populated load balancer.
Change-Id: Id0f347f9d89e6ca801edb9044302216da4ffbb3b
Story: 2004961
2019-02-07 18:17:09 +03:00
Erik Olof Gunnar Andersson
404600e0e2 Cleaning up logging
* Don't shadow LOG from outer scope.
* Always lazy-load logging.
* Fixed an invalid log line.

Change-Id: Ief40a3de554886c66f2063a0855b22ee1b5b758e
2019-02-06 22:45:05 -08:00
Zuul
c00fd3e818 Merge "Improve local hacking checks test coverage" 2019-02-06 23:28:26 +00:00
Michael Johnson
5d7f10f6b8 Fix flavors support when using spares pool
This patch validates that a flavor is compatible with using spares
pool amphora. It will also update the amphora-agent config after
a spares pool amphora has been allocated.

This patch enables the ability to update a running amphora's agent
configuration and have the mutatable options be adopted.

The following amphora agent configuration options can be updated:
heartbeat_key
controller_ip_port_list
heartbeat_interval
loadbalancer_topology

This patch adds the support to the amphora-agent and the amphora
driver. A follow on patch will expose this capabililty via the
amphora admin API.

Change-Id: I97bdf5188808193516509f20767e82c0f8d2f5a5
2019-02-05 14:49:10 -08:00
Zuul
ddcae3e229 Merge "Fix the amphora noop driver" 2019-02-05 21:44:29 +00:00
Michael Johnson
987d14406c Fix the amphora noop driver
The dual-amp-down fix added an amphora parameter to the amphora driver
interface, but failed to update the driver base and the noop driver.
This patch corrects that oversight.

Depends-On: https://review.openstack.org/634992
Change-Id: I7bd63c933f8e7cd10ff5c89fafbbb09e8cc9e3e1
2019-02-05 17:34:53 +00:00
Corey Bryant
674f007d50 Add missing import octavia/opts.py
Fix 'tox -e genconfig' by adding missing import.

Change-Id: Ibefeee498cd16e5262b231936a25b1a4ba98a94e
Story: 2004914
2019-02-01 10:51:52 -05:00
Zuul
7dc8085e21 Merge "Support remote debugging with PyDev" 2019-01-31 21:41:58 +00:00
Zuul
979144f2fd Merge "Fix a topology bug in flavors support" 2019-01-30 01:28:34 +00:00
Zuul
71914bc2af Merge "Add compute flavor support to the amphora driver" 2019-01-30 01:28:33 +00:00
Zuul
7a601c3218 Merge "Update the amphora driver for flavor support." 2019-01-30 01:28:31 +00:00
Zuul
6bdc44cfb9 Merge "Add flavor docs and releae notes" 2019-01-29 23:52:30 +00:00
Zuul
22df2e0f48 Merge "Add provider driver capabilities API" 2019-01-29 10:13:57 +00:00
Zuul
c21e6caf62 Merge "Adds flavor support to the amphora driver" 2019-01-29 10:13:55 +00:00
Zuul
275965d3a1 Merge "Add flavors/flavor_profile api-ref" 2019-01-29 10:13:53 +00:00
Zuul
081c330cdf Merge "Add flavor, flavor_profile table and their APIs" 2019-01-29 10:13:51 +00:00
Michael Johnson
8d45d48731 Fix VIP address DB storage size to support IPv6
An earlier patch[1] attempted to fix the vip address storage size in the
octavia database, however it issued the alembic "alter_column" command
incorrectly and the column size was not fixed.

This patch corrects that with another alembic migration that uses the correct
syntax.

[1] https://review.openstack.org/#/c/339826

Change-Id: Ib577f92be38fa9a1c84571729b0236913da8d9d2
2019-01-28 10:09:59 -08:00
Zuul
6f96401e9c Merge "Clarify the amp_ssh_key_name configuration setting." 2019-01-27 01:03:48 +00:00
Michael Johnson
8ec61f4f23 Fix a topology bug in flavors support
This patch fixes an oversight in the addition of flavors support in the
amphora driver[1]. The amphora-agent configuration file was still getting
the topology selected in the configuration file as opposed to the
topology selected in the flavor.

This is an additional patch at the end of the chain as it leverages
changes that were made in later flavor patches that pass the flavor
into the taskflow flow.

A follow on patch will address spares pool amphora.

[1] https://review.openstack.org/#/c/621323

Change-Id: I4c2b398b562970f128e06794690ffd7c2977db08
2019-01-25 21:02:43 +00:00
Michael Johnson
69f1753903 Add compute flavor support to the amphora driver
This patch adds a new flavor capability to the amphora driver called
'compute_flavor'. This allows an amphora flavor to specify a compute
(nova) flavor to be used for the load balancer instances.

Change-Id: I8626eebd906c935a47d3e3510d1dfefae307c4e9
2019-01-25 21:02:17 +00:00
Michael Johnson
aa82d51961 Update the amphora driver for flavor support.
This patch updates the amphroa driver to pass the flavor dictionary
over to the controller worker at load balancer creation time.
This flavor dictionary is then inserted into the load balancer
creation flow.

Change-Id: I615937fdf9edf335fb18999f1b7c11eb6202a3d1
2019-01-25 21:01:27 +00:00
Michael Johnson
5e1cdac4c9 Add flavor docs and releae notes
This patch adds an administrator guide for flavors and a release note for
the new flavors feature.

Depends-On: https://review.openstack.org/#/c/624294/
Change-Id: Id6b107994515776e2996d949186c03df4b4295a5
2019-01-25 20:41:03 +00:00
Michael Johnson
1afeeb95d3 Add provider driver capabilities API
This patch adds an API that allows operators to query a provider driver
for the list of supported flavor capabilities.

Change-Id: Ia3d62acdc3b1af2e666f58d32a06d2238706dee6
2019-01-25 12:38:03 -08:00
Michael Johnson
0b1fe6a526 Adds flavor support to the amphora driver
This patch adds support for flavor metadata validation by the amphora driver
and support for setting the load balancer topology via a flavor.
It also adds "flavor_id" to the load balancer table in the database.

Change-Id: I8eae870abdb20dc32917957e32606deef387ec88
2019-01-25 20:34:11 +00:00
Michael Johnson
15282ff9d6 Add flavors/flavor_profile api-ref
This patch adds the api-ref updates for the new flavors and flavor profile
API.

Change-Id: I11ab9af188731a1eaf1f402c4d55a944dc85ea88
2019-01-25 12:30:24 -08:00
Pradeep Kumar Singh
637009ecd0 Add flavor, flavor_profile table and their APIs
This patch adds flavor and flavor_profile tables.
It also implements flavors and flavorprofiles apis.

Partially-Implements: Blueprint octavia-lbaas-flavors
Co-Authored-By: Michael Johnson <johnsomor@gmail.com>

Change-Id: I99a673438458757d0acdaa46dd8ee041edb3be9c
2019-01-25 12:25:13 -08:00
Zuul
8b4a01c5bb Merge "Update api-ref for tag filtering" 2019-01-25 02:37:43 +00:00
Zuul
3980769247 Merge "Fix prefix for vip_ipv6" 2019-01-25 00:46:09 +00:00
Zuul
44b723e3a0 Merge "Support to filter resources by tags" 2019-01-24 09:44:15 +00:00
Zuul
2015e7f9a8 Merge "Add octavia-v2-dsvm-tls-barbican check job" 2019-01-24 09:39:58 +00:00
Zuul
d0664582ee Merge "Workaround for a dnf bug" 2019-01-24 09:37:26 +00:00
Michael Johnson
fb0bbb9826 Update api-ref for tag filtering
This patch also updates the API version to 2.5 to represent the tags
support.

Change-Id: Ia57724c231c10efad9cee46be4969fa276fff8b1
Co-Authored-By: Lingxian Kong <anlin.kong@gmail.com>
2019-01-22 00:55:19 +00:00
Lingxian Kong
5df9ad49b3 Support to filter resources by tags
Add 'tags', 'tags-any', 'not-tags', 'not-tags-any' param keys for
resource query.

Doc reference:
http://specs.openstack.org/openstack/api-wg/guidelines/tags.html#filtering-and-searching-by-tags

Change-Id: Ie752aa8e744d54c4909b97876dee450293d29908
Story: 2004810
Task: 28970
2019-01-22 13:46:24 +13:00
Zuul
6786235f02 Merge "Exit with error if DIB output dir doesn't exist" 2019-01-18 20:15:16 +00:00
Michael Johnson
06f2c6d90a Add octavia-v2-dsvm-tls-barbican check job
Add the octavia-v2-dsvm-tls-barbican job to the master Octavia check
jobs as non-voting.

Change-Id: I711ffd00c25b22644da7f755b5e8939128b8af91
2019-01-18 06:16:45 +00:00
Michael Johnson
fd3c04ec3a Clarify the amp_ssh_key_name configuration setting.
This patch updates the description for the amp_ssh_key_name configuration
setting to clarify that this is a nova keypair and optional.

Change-Id: I77c938c5e27abb312047e28bc1a73dc47e47fd97
2019-01-14 15:13:02 -08:00
Itzik Brown
3745e1f55d Fix typo in doc
Change-Id: Ibf780ac971fc40f7efb1ebe78c97c565ccafea6b
2019-01-14 08:58:41 +02:00
Zuul
d0c499dbd6 Merge "Fix missing print format error" 2019-01-11 05:09:49 +00:00
Michael Johnson
ff1e933eef Improve local hacking checks test coverage
This patch improves the unit test coverage for the local hacking checks.
It also removes the "no_author_tags" check as it is now covered in the
main hacking rule H105.

Change-Id: I4029f4fa2e28f4f50c1897b6216c0d8557b2a56b
2019-01-10 16:25:21 -08:00