516 Commits

Author SHA1 Message Date
Jenkins
92989ec26a Merge "Improve logging in octavia.controller" 2015-10-02 21:48:41 +00:00
Jenkins
630d39f6cd Merge "Improve logging in octavia.common" 2015-10-02 21:47:24 +00:00
Jenkins
b1e05bfbd6 Merge "Improve logging in octavia.network" 2015-10-02 21:46:34 +00:00
Jenkins
477ed5d781 Merge "Improve logging in octavia.amphorae" 2015-10-02 21:45:23 +00:00
Jenkins
5f43c69324 Merge "Improve logging in octavia.certificates" 2015-10-02 21:43:47 +00:00
Bertrand Lallau
93f84e09f4 Unify constants usage in taskflow flows
this patch finish work started in commit
and commit #33ca8f3cc37f002b83fd3d030b99d091c4134591

_ replace 'object' string to constants.OBJECT
_ WAIT_FOR_AMPHORA constants has been defined

Change-Id: I563ccc9429909441e5c69fd5f01d4dabc1b94e28
Related-Bug: #1461679
2015-10-02 22:03:08 +02:00
Cedric Brandily
c287c9f447 Improve logging in octavia.controller
We should delegate (when possible) formatting to the logger in order to
perform formatting only when needed, by using:

 LOG.<level>(message, data)

instead of:

 LOG.<level>(message % data)

and

 try:
   ...
 except ...:
   LOG.exception("lorem ipsum")

instead of:

 try:
   ...
 except ... as e:
   LOG.error("lorem ipsum: %s:", e)

This change removes also some incorrect usages of _LW in debug logs.

Change-Id: I6c62ceffbb99d2dee76160d398c6166132f6471c
2015-10-02 20:54:05 +02:00
Jenkins
cc67be5e5f Merge "Replace wrong Nova references to Compute ones" 2015-10-02 18:09:17 +00:00
Jenkins
5e289b9b5c Merge "Remove oslo-incubator files" 2015-10-02 18:01:16 +00:00
Jenkins
b6ea535662 Merge "Update some release related texts" 2015-10-02 16:27:10 +00:00
Jenkins
c4c81bfffd Merge "Allow drivers to be overridden for devstack" 2015-10-02 15:26:28 +00:00
Jenkins
da3551bfc6 Merge "Get noop drivers to function within flows" 2015-10-02 15:25:07 +00:00
Cedric Brandily
3d91ce44ca Improve logging in octavia.common
We should delegate (when possible) formatting to the logger in order to
perform formatting only when needed, by using:

 LOG.<level>(message, data)

instead of:

 LOG.<level>(message % data)

and

 try:
   ...
 except ...:
   LOG.exception("lorem ipsum")

instead of:

 try:
   ...
 except ... as e:
   LOG.error("lorem ipsum: %s:", e)

This change removes also some incorrect usages of _ in info logs.

Change-Id: I0ae32da1570301acf90b65de620e437ce0f1dfdd
2015-10-02 11:38:26 +00:00
Cedric Brandily
c656da7168 Improve logging in octavia.amphorae
We should delegate (when possible) formatting to the logger in order to
perform formatting only when needed, by using:

 LOG.<level>(message, data)

instead of:

 LOG.<level>(message % data)

and

 try:
   ...
 except ...:
   LOG.exception("lorem ipsum")

instead of:

 try:
   ...
 except ... as e:
   LOG.error("lorem ipsum: %s:", e)

Change-Id: I586d1bcfda61b69a60174934a6001c05d78dca9e
2015-10-02 11:28:04 +00:00
Cedric Brandily
eccb4478c2 Improve logging in octavia.api
We should delegate (when possible) formatting to the logger in order to
perform formatting only when needed, by using:

 LOG.<level>(message, data)

instead of:

 LOG.<level>(message % data)

and

 try:
   ...
 except ...:
   LOG.exception("lorem ipsum")

instead of:

 try:
   ...
 except ... as e:
   LOG.error("lorem ipsum: %s:", e)

This change corrects some incorrect indentations in logs

Change-Id: I4a3b7cead3abf5c4f801853b78a88c683bcbb5ae
2015-10-02 11:19:08 +00:00
Cedric Brandily
76437fdb67 Improve logging in octavia.network
We should delegate (when possible) formatting to the logger in order to
perform formatting only when needed, by using:

 LOG.<level>(message, data)

instead of:

 LOG.<level>(message % data)

and

 try:
   ...
 except ...:
   LOG.exception("lorem ipsum")

instead of:

 try:
   ...
 except ... as e:
   LOG.error("lorem ipsum: %s:", e)

Change-Id: I84ff1a2b55c026fb69f83d6a0741bbde0e65409e
2015-10-02 11:06:43 +00:00
Jenkins
dc56d9bfba Merge "Unify constants usage final instalment" 2015-10-02 10:20:59 +00:00
Cedric Brandily
6f16648bcf Improve logging in octavia.cmd
We should delegate (when possible) formatting to the logger in order to
perform formatting only when needed, by using:

 LOG.<level>(message, data)

instead of:

 LOG.<level>(message % data)

and

 try:
   ...
 except ...:
   LOG.exception("lorem ipsum")

instead of:

 try:
   ...
 except ... as e:
   LOG.error("lorem ipsum: %s:", e)

Change-Id: Ibbbd4c9bf20ffc4387bca7f04e51a9e8759ac882
2015-10-02 10:13:41 +00:00
Cedric Brandily
e7eaba1dfb Improve logging in octavia.certificates
We should delegate (when possible) formatting to the logger in order to
perform formatting only when needed, by using:

 LOG.<level>(message, data)

instead of:

 LOG.<level>(message % data)

and

 try:
   ...
 except ...:
   LOG.exception("lorem ipsum")

instead of:

 try:
   ...
 except ... as e:
   LOG.error("lorem ipsum: %s:", e)

Change-Id: I8052ebd026c380499c19562bcb29b05cd8a7f5f0
2015-10-02 09:21:52 +00:00
Bertrand Lallau
dd1e3c0797 Replace wrong Nova references to Compute ones
Octavia code base should be more generic, because containers
can be used in a near future.
This patch corrects naming methods and fix some docstrings.

Change-Id: I5157ebaf8a044daf6b0cee5bada5591b7ef50bf1
2015-10-02 09:52:17 +02:00
Tony Breeds
d41599e5a5 Add Pillow to docs-requirements.txt
NOTE(tonyb) Pillow isn't directly needed but it's pulled in via
 Collecting Pillow (from blockdiag-> ...)
So cap as per global-requirements until https://launchpad.net/bugs/1501995
is properly fixed

Change-Id: I4b0716569dc8058ccb28cc569f381da5bc30d6a6
2015-10-02 15:13:34 +10:00
Michael Johnson
fc2e5b9458 Update some release related texts
Fixes a typo in the setup.cfg
Sets the development status to Beta
Includes some lines in the README.rst to allow release-tools be
able to create release summary e-mails.
Adds some bling to our README.rst

Change-Id: I6564c8ab661523c60d341a01f3ff431d578621e8
2015-10-01 23:58:03 +00:00
Bertrand Lallau
44f7131818 Remove oslo-incubator files
Oslo 'cache' module is not used, and just use space.

Change-Id: Iae6b2e11a0f1e2a5ff33b69a6be1643037ddba58
2015-10-01 22:25:50 +02:00
Bertrand Lallau
33ca8f3cc3 Unify constants usage final instalment
this patch finish work started in commit #b3776a4110c6ac35358ca03ffee8b2defd85cea3
It replace static strings usage to constants during taskflow store definition.

Change-Id: I25a497deefe01a4ba5b93309e33f75d2ab630d80
Related-Bug: #1461679
2015-10-01 16:26:24 +02:00
Brandon Logan
01abc3f34c Allow drivers to be overridden for devstack
Change-Id: Ia26bd8cb28dccbb021b2a2f64a9b7e6ef498ff4c
2015-10-01 01:39:36 -05:00
Bertrand Lallau
b3776a4110 Unify constants usage in taskflow flows
a number of the flows use static strings for names in task flow
storage instead of using constants. This patch unified constants usage.

Closes-Bug: #1461679
Change-Id: I37edac69be64be39b4560b3b26460415144ac3bb
2015-09-30 21:46:50 +02:00
Jenkins
b821819cbb Merge "Fix a typo in the .coveragerc file" 2015-09-30 18:42:32 +00:00
Michael Johnson
4f44ef2f1f Add a missing tox environment "venv"
The venv tox enviroment is required for the package release
to pypi.

Change-Id: I5b6fda3b3efc86dd2fdb7b7d98fb39c14708f89b
2015-09-30 16:33:07 +00:00
Brandon Logan
0c80a3bff1 Get noop drivers to function within flows
The noop drivers suffered from not being updated and just not being tested
with being called within flows like normal real op drivers.  This gets the noop
drivers to succeed when called liked other drivers.  They do not do anything
and will return fake information whenever it is required they return data.
This can be improved later so that they actually do their own data store, but
that would require a much larger update and I'm not sure there's much value
in it.

Change-Id: I2627ed35c0f576f8cfa258b542e5bdb4be03dac8
Closes-Bug: #1501190
2015-09-30 02:28:56 -05:00
Michael Johnson
3a91370d38 Fix a typo in the .coveragerc file
Coverage now aborts the run when the configuration file has unknown
settings.  This patch fixes a typo in the .coveragerc file that
would cause coverage jobs to fail.

A global requirements change will also be necessary to exclude
version 4.0 of coverage as it causes tests to fail that
do not fail outside of coverage or with earlier versions.
Tracked here: https://review.openstack.org/#/c/228581/

Global requirements changes come in as separate patches, so
I am not creating a dependency. 

Change-Id: Ifbbf2096303770e393e666e3562c83d863e82f15
2015-09-29 17:37:35 +00:00
Zhao Lei
585bff3b6a Remove quotes from subshell call in bash script
Always no quotes for $() statement.

We don't need quotes to hold blanks in result:
 # i=$(echo 1 2 3)
 # echo $i
 1 2 3
 #

These quotes can make something wrong in some case:
 # i=$(echo '!')
 #
 # i="$(echo '!')"
 -bash: !: event not found
 #

No real problem for current code, only to use a better code style.

Change-Id: I84c23863e73684f0c22a90e447af69dec4789523
Signed-off-by: Zhao Lei <zhaolei@cn.fujitsu.com>
2015-09-23 19:00:01 +08:00
Jenkins
a474130c8d Merge "Update controller logging" 2015-09-21 19:39:48 +00:00
Michael Johnson
833d633975 Increase the number of network call retries
On hosts without nested virtualization enabled, network calls
can timeout.  This triples the number of retries Octavia attempts
for networking calls.

Change-Id: I31ff9cbbdb073d0ee92971894fac86a2245c93f8
2015-09-21 19:13:13 +00:00
Michael Johnson
55ad390f4a Update controller logging
Adjusts some controller worker log entries up to info from debug
Adjusts some housekeeping manager log entries down from info to debug

Change-Id: I970bd7513175bd08b0733fda695336a5e5e09bd0
2015-09-21 03:55:40 +00:00
Jenkins
57ce15f268 Merge "Make keystone verify configurable" 2015-09-18 22:35:22 +00:00
Jenkins
a445215678 Merge "Don't build amphora image if one is available" 2015-09-18 18:31:52 +00:00
Michael Johnson
0000908ab0 Don't build amphora image if one is available
The devstack plugin.sh script will always build and load an
amphora image.  This patch checks for an existing amphora
image and if one exists it will not build another.

Change-Id: Ifce40b0af9da715d44bab8ec437f844ccf638f52
2015-09-18 03:44:30 +00:00
Jenkins
5393e7e968 Merge "Updated from global requirements" 2015-09-17 20:52:15 +00:00
Jenkins
883d5a32fd Merge "Remove SQL GET request from UpdateAmphoraComputeId" 2015-09-17 20:49:52 +00:00
ptoohill1
2494c1f920 Make keystone verify configurable
In some cases, such as test environements, it is required
to run with an insecure keystone connection. Allow for a
configuration option to set the verify flag.

Change-Id: I4b0658322b5d737b116d5659551fb2fe4f9e68a1
2015-09-17 11:30:51 -05:00
OpenStack Proposal Bot
b3846ba908 Updated from global requirements
Change-Id: I6b212eff61ed51f24f5f716e4c776f3cc6e339de
2015-09-17 12:15:32 +00:00
Bertrand Lallau
1faae4b6c4 Remove SQL GET request from UpdateAmphoraComputeId
"UpdateAmphoraComputeId" task actually return an object and perform
a SQL request not used by any taskflow.
"UpdateAmphoraComputeId" task usage in amphora_flows doesn't
provides anything. Hence SQL request and return value can be avoided.

Change-Id: I93eca3193435fd59fc2d73fc1d820ae51fde3e03
2015-09-17 10:31:38 +02:00
Jenkins
e2a50cac93 Merge "Move roadmap to wiki" 2015-09-16 21:18:55 +00:00
Stephen Balukoff
943da7d9af Move roadmap to wiki
Since the roadmap is usually one of the first documents
that people curious about Octavia are likely to read, it makes
sense to move this to somewhere both more easily found by new
people, and more quickly updated by project leadership. As such,
this commit removes the ROADMAP.rst file from this repo, and
moves it to: https://wiki.openstack.org/wiki/Octavia/Roadmap

Change-Id: Ibce2191fbfb33c09af0f9ae0d839e1fabcf788b5
2015-09-15 20:19:26 -07:00
Jenkins
ca2a2ed1bc Merge "Fix issues uncovered by neutron lbaas tempest tests" 2015-09-15 23:14:51 +00:00
Brandon Logan
d14ebc2cdf Fix issues uncovered by neutron lbaas tempest tests
Updating a listener caused issues because SNI was not being appropriately
handles on a listener update.  This has been "fixed" but another patch will be
needed to make sure that every listener update does not clear out the list. I
think it is best to leave that for another review though.

This also fixes the bug where security groups were not getting cleaned up when
a load balancer is deleted.  Since neutron does not synchronously remove a
security group from a port, a retry mechanism had to be used and thus more
config options to tune the interval and max attempts.

Change-Id: I0434b8ced144ab08413b91569bd008295ef1784e
Closes-Bug: #1464953
2015-09-15 18:02:40 -05:00
Jenkins
cb1efcc43a Merge "Add health_manager config options" 2015-09-15 08:40:32 +00:00
Bertrand Lallau
0055d33e10 Add health_manager config options
Change-Id: Ibe25f9354071c35c3ba2c5388c20f99750dfc71c
2015-09-13 22:15:16 +02:00
Bertrand Lallau
deedeaa5e7 Correct status_update_threads configuration help
Change-Id: I82d46ccb8025f02018ecab665ff69e00c26c9c82
2015-09-13 22:13:22 +02:00
Bertrand Lallau
068862dc72 Remove bad INFO log "Starting Octavia API server"
This log is also display for health_manager and house_keeping service.
Api service already display "Starting API server on..." in INFO level.

Change-Id: I0a3ff91b556accdfadbad797488d17ae7a95d85b
2015-09-12 09:03:35 +02:00