24ef5c9d96
The controller worker flow to update the data model was simplistically setting new attribute values to whatever made it through the API's verification / syntax check. While this works well for simple attributes, if the attribute happens to be a reference to another object, or if updating that attribute were to affect some other attribute or linked object, this would case the data model update to fail. The root of the issue here is that the data model code does not currently duplicate all the functionality that is handled by SQLAlchemy for the database models. This was complicated by the fact that we have at the present time, essentially no tests for pure data model updates (ie. which don't hit the underlying repository / database). In particular, this update corrects update problems for pool.session_persistence attributes, as well as listener.default_pool_id attribute updates. Closes-Bug: 1544851 Change-Id: I8617dcb38013456d5ba5e10a92e25be0c07e3e8d
45 lines
1.4 KiB
Python
45 lines
1.4 KiB
Python
# Copyright 2015 Hewlett-Packard Development Company, L.P.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
#
|
|
|
|
import mock
|
|
|
|
from octavia.controller.worker.tasks import model_tasks
|
|
import octavia.tests.unit.base as base
|
|
|
|
|
|
class TestObjectUpdateTasks(base.TestCase):
|
|
|
|
def setUp(self):
|
|
|
|
self.listener_mock = mock.MagicMock()
|
|
self.listener_mock.name = 'TEST'
|
|
|
|
super(TestObjectUpdateTasks, self).setUp()
|
|
|
|
def test_delete_model_object(self):
|
|
|
|
delete_object = model_tasks.DeleteModelObject()
|
|
delete_object.execute(self.listener_mock)
|
|
|
|
self.listener_mock.delete.assert_called_once_with()
|
|
|
|
def test_update_listener(self):
|
|
|
|
update_attr = model_tasks.UpdateAttributes()
|
|
update_attr.execute(self.listener_mock,
|
|
{'name': 'TEST2'})
|
|
|
|
self.listener_mock.update.assert_called_once_with({'name': 'TEST2'})
|