You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
The base64_sha_string method is used to set a base64-encoded peer name in HAProxy. There are cases where the peer name can start with an hypen which is troublesome when used in HAProxy CLI. Specifically, HAProxy fails to reload when local peer name starts with '-x' . When this is the case, an amphora goes to provisioning status ERROR and later is scheduled for failover by the Octavia Health Manager service. A new amphora UUUID is assigned and base64 encoded, hopefully not starting with '-x' again. However, this is far from being ideal -- we incur in a dataplane disruption (single topology) or reduce HA capabilities (active-standby topology) for some time. Four possible options: a) add prefix to peer name b) change b64encode altchars c) quote peer name in haproxy CLI command d) substitute first character if hyphen Option a) and b) are not backward compatible with running amphorae. Peer names of existing amphorae that do not start with hypen but contain hyphen at any other position would get different peer names. Option c) would nonetheless still require an amphora image update to add quotes in the HAProxy init service file. Continuing to generate peer names with hyphens at begininng of the string is avoidable and recommended. Option d), while also requiring an amphora image update, it would get rid of hyphens in begining of the peer names. It is also backward compatible with all running amphorae, except for those starting with hyphen but are broken anyways. This patch takes option d). It substitutes hyphen with 'x' character.  https://github.com/haproxy/haproxy/issues/644 Task: 39850 Story: 2007714 Change-Id: Ib0fc26877710dea423a5ebcf1f71077665404377
|2 years ago|
|notes||2 years ago|
|source||2 years ago|