openstack
/
openstack-ansible-lxc_container_create
Code Issues Proposed changes

Remove 'ignore_errors: true' in favor of 'failed_when: false' 

This change removes the use of 'ignore_errors: true' because it causes deployers
to see red output and a stacktrace, which traditionally means something is broken,
even when the failure is known to have a fall back option or be intentional. This
conversion will provide a generally cleaner interface.

It should be noted that the 'failed' filter will still function normally. Tasks
with the 'failed_when: false' option will still be marked as 'failed' in any
registered variable. This change simply makes the output look cleaner.

Change-Id: Ia5c6d38a33e96c969116606859a9a60c6a79a663
Closes-Bug: #1633438
Signed-off-by: Kevin Carter <kevin.carter@rackspace.com>
This commit is contained in:
Kevin Carter 2016-10-14 16:44:08 -05:00
parent d2c79015d3
commit 9db66dbee7
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/test-containers-functional.yml
View File

@ -83,7 +83,7 @@
- name: Test connectivity to external address
shell: ping -c 3 8.8.8.8
register: ping_external_address
ignore_errors: true
failed_when: false
- name: Verify connectivity to external address
assert:
that: