openstack/openstack-ansible-openstack_openrc
Code Issues Proposed changes

Update file and directory permissions

Browse Source 
Currently the clouds.yaml directory permissions are hardcoded and
missing the execute bit. When using this role with a default location in
/etc/openstack, normal system users are not able to read the
configuration file.

This commit adds variable overrides for the file and directory
permissions, as well as correcting the directory permissions.

Change-Id: I2380030235d455ff4dd0ea7658c7146ece60db81
Closes-Bug: #1689837
This commit is contained in:
Jason Hedden 2017-05-10 09:54:41 -05:00
parent d572621f64
commit 428e7c55f6
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
defaults/main.yml
View File

@ -32,11 +32,14 @@ openrc_insecure: "{{ (keystone_service_adminuri_insecure | bool or keystone_serv
openrc_file_dest: "{{ ansible_env.HOME }}/openrc"
openrc_file_owner: "{{ ansible_user_id }}"
openrc_file_group: "{{ ansible_user_id }}"
openrc_file_mode: "0600"
## Create clouds.yml file
openrc_openstack_client_config_dir_dest: "{{ ansible_env.HOME }}/.config/openstack"
openrc_openstack_client_config_dir_owner: "{{ ansible_user_id }}"
openrc_openstack_client_config_dir_group: "{{ ansible_user_id }}"
openrc_openstack_client_config_dir_mode: "0700"
openrc_clouds_yml_file_dest: "{{ openrc_openstack_client_config_dir_dest }}/clouds.yaml"
openrc_clouds_yml_file_owner: "{{ ansible_user_id }}"
openrc_clouds_yml_file_group: "{{ ansible_user_id }}"
openrc_clouds_yml_file_mode: "0600"

6
tasks/main.yml
View File

@ -19,7 +19,7 @@
dest: "{{ openrc_file_dest }}"
owner: "{{ openrc_file_owner }}"
group: "{{ openrc_file_group }}"
mode: "0600"
mode: "{{ openrc_file_mode }}"
tags:
- openstack_openrc-config
@ -28,7 +28,7 @@
dest: "{{ openrc_openstack_client_config_dir_dest }}"
owner: "{{ openrc_openstack_client_config_dir_owner }}"
group: "{{ openrc_openstack_client_config_dir_group }}"
mode: "0600"
mode: "{{ openrc_openstack_client_config_dir_mode }}"
state: directory
tags:
- openstack_openrc-install
@ -39,6 +39,6 @@
dest: "{{ openrc_clouds_yml_file_dest }}"
owner: "{{ openrc_clouds_yml_file_owner }}"
group: "{{ openrc_clouds_yml_file_group }}"
mode: "0600"
mode: "{{ openrc_clouds_yml_file_mode }}"
tags:
- openstack_openrc-config