Update patch set 7
Patch Set 7: Code-Review-1 (4 comments) Patch-set: 7 Label: Code-Review=-1
This commit is contained in:
parent
c229aa853c
commit
f2c86e3670
90
7dd77d2f6b673611503cd411a066096160e5e4ad
Normal file
90
7dd77d2f6b673611503cd411a066096160e5e4ad
Normal file
@ -0,0 +1,90 @@
|
||||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5a9d85d2_c1d31737",
|
||||
"filename": "CONTRIBUTING.rst",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 2,
|
||||
"author": {
|
||||
"id": 6816
|
||||
},
|
||||
"writtenOn": "2016-06-21T13:55:48Z",
|
||||
"side": 1,
|
||||
"message": "The length of this line must match the one above.",
|
||||
"range": {
|
||||
"startLine": 2,
|
||||
"startChar": 0,
|
||||
"endLine": 2,
|
||||
"endChar": 24
|
||||
},
|
||||
"revId": "7dd77d2f6b673611503cd411a066096160e5e4ad",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5a9d85d2_4196074d",
|
||||
"filename": "doc/source/conf.py",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 53,
|
||||
"author": {
|
||||
"id": 6816
|
||||
},
|
||||
"writtenOn": "2016-06-21T13:55:48Z",
|
||||
"side": 1,
|
||||
"message": "2016",
|
||||
"range": {
|
||||
"startLine": 53,
|
||||
"startChar": 13,
|
||||
"endLine": 53,
|
||||
"endChar": 17
|
||||
},
|
||||
"revId": "7dd77d2f6b673611503cd411a066096160e5e4ad",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5a9d85d2_0136bf51",
|
||||
"filename": "run_tests.sh",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 29,
|
||||
"author": {
|
||||
"id": 6816
|
||||
},
|
||||
"writtenOn": "2016-06-21T13:55:48Z",
|
||||
"side": 1,
|
||||
"message": "I think it\u0027ll be best to grab an updated version of this file in https://github.com/openstack/openstack-ansible-security/blob/master/run_tests.sh to cater for CentOS/RHEL testing. That said, it can always be added later when support for those platforms is added.",
|
||||
"range": {
|
||||
"startLine": 20,
|
||||
"startChar": 0,
|
||||
"endLine": 29,
|
||||
"endChar": 2
|
||||
},
|
||||
"revId": "7dd77d2f6b673611503cd411a066096160e5e4ad",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "5a9d85d2_c1bcb76e",
|
||||
"filename": "tox.ini",
|
||||
"patchSetId": 7
|
||||
},
|
||||
"lineNbr": 0,
|
||||
"author": {
|
||||
"id": 6816
|
||||
},
|
||||
"writtenOn": "2016-06-21T13:55:48Z",
|
||||
"side": 1,
|
||||
"message": "Can you grab the updated version of this file from https://github.com/openstack/openstack-ansible-memcached_server/blob/master/tox.ini for the improvements just patched?",
|
||||
"revId": "7dd77d2f6b673611503cd411a066096160e5e4ad",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue
Block a user