Fix linting issues for ansible-lint 3.4.1

Preparing this role for the ansible-lint version bump

Change-Id: I9cd230ba21008afca3ed21cb20e49a80a2afe6c4

defaults/main.yml

@@ -19,6 +19,7 @@ debug: False
 # Set the package install state for distribution packages
 # Options are 'present' and 'latest'
 designate_package_state: "latest"
+designate_pip_package_state: "latest"
 
 ## The git source/branch
 designate_git_repo: https://git.openstack.org/openstack/designate

handlers/main.yml

@@ -20,8 +20,7 @@
     - Restart designate services
 
 - name: Reload upstart init scripts
-  shell: |
-    initctl reload-configuration
+  command: initctl reload-configuration
   notify:
     - Restart designate services
 

tasks/designate_db_setup.yml

@@ -17,8 +17,10 @@
   command: "{{ designate_bin }}/designate-manage database sync"
   become: yes
   become_user: "{{ designate_system_user_name }}"
+  changed_when: false
 
 - name: Perform a Designate Pool Manager Cache sync
   command: "{{ designate_bin }}/designate-manage pool-manager-cache sync"
   become: yes
   become_user: "{{ designate_system_user_name }}"
+  changed_when: false

tasks/designate_install.yml

@@ -29,7 +29,7 @@
 - name: Install requires pip packages
   pip:
     name: "{{ designate_requires_pip_packages | join(' ') }}"
-    state: latest
+    state: "{{ designate_pip_package_state }}"
     extra_args: >-
       {{ (pip_install_upper_constraints is defined) | ternary('--constraint ' + pip_install_upper_constraints | default(''),'') }}
       {{ pip_install_options | default('') }}
@@ -105,7 +105,7 @@
 - name: Install pip packages
   pip:
     name: "{{ designate_pip_packages | join(' ') }}"
-    state: latest
+    state: "{{ designate_pip_package_state }}"
     virtualenv: "{{ designate_bin | dirname }}"
     virtualenv_site_packages: "no"
     extra_args: >-

tasks/main.yml

@@ -23,8 +23,10 @@
     - "{{ ansible_os_family | lower }}.yml"
   tags:
     - always
+
 - name: Check init system
   command: cat /proc/1/comm
+  changed_when: false
   register: _pid1_name
   tags:
     - always