Fix linting issues for ansible-lint 3.4.1

Preparing this role for the ansible-lint version bump

Change-Id: I3aa90b44d174bd806f783198183c5092ab1297e4

defaults/main.yml

@@ -20,9 +20,10 @@ gnocchi_identity_only: False
 #: Enable for debug logging level
 debug: false
 
-# Set the package install state for distribution packages
+# Set the package install state for distribution and pip packages
 # Options are 'present' and 'latest'
 gnocchi_package_state: "latest"
+gnocchi_pip_package_state: "latest"
 
 # Toggle keystone authentication for gnocchi
 gnocchi_keystone_auth: no

tasks/gnocchi_ceph_python_libs.yml

@@ -15,6 +15,7 @@
 
 - name: Register rados module path
   command: python -c 'import rados; print rados.__file__'
+  changed_when: false
   register: rados_module_path
 
 - name: Link rados module into the venv

tasks/gnocchi_db_setup.yml

@@ -17,3 +17,4 @@
   command: "{{ gnocchi_bin }}/gnocchi-upgrade {{ gnocchi_db_sync_options }}"
   become: yes
   become_user: "{{ gnocchi_system_user_name }}"
+  changed_when: false

tasks/gnocchi_init_upstart.yml

@@ -27,10 +27,10 @@
     - Restart Apache
 
 - name: Reload init scripts
-  shell: |
+  command: initctl reload-configuration
-    initctl reload-configuration
   when: upstart_init | changed
   notify:
     - Restart Gnocchi API services
     - Restart Gnocchi extra services
     - Restart Apache
+  changed_when: false

tasks/gnocchi_install.yml

@@ -53,7 +53,7 @@
 - name: Install required pip packages
   pip:
     name: "{{ gnocchi_required_pip_packages | join(' ') }}"
-    state: latest
+    state: "{{ gnocchi_pip_package_state }}"
     extra_args: "{{ pip_install_options_fact }}"
   register: install_packages
   until: install_packages|success
@@ -135,7 +135,7 @@
 - name: Install pip packages
   pip:
     name: "{{ gnocchi_pip_packages | join(' ') }}"
-    state: latest
+    state: "{{ gnocchi_pip_package_state }}"
     virtualenv: "{{ gnocchi_bin | dirname }}"
     virtualenv_site_packages: "no"
     extra_args: "{{ pip_install_options_fact }}"

tasks/main.yml

@@ -26,6 +26,7 @@
 
 - name: Check init system
   command: cat /proc/1/comm
+  changed_when: false
   register: _pid1_name
   tags:
     - always