Fix linting issues for ansible-lint 3.4.1

Preparing this role for the ansible-lint version bump

Change-Id: I7f46254ee0270bcdeb49b1b059528fa862068a69

defaults/main.yml

@@ -22,9 +22,10 @@ heat_ceilometer_enabled: False
 ## Verbosity Options
 debug: False
 
-# Set the package install state for distribution packages
+# Set the package install state for distribution and pip packages
 # Options are 'present' and 'latest'
 heat_package_state: "latest"
+heat_pip_package_state: "latest"
 
 heat_git_repo: https://git.openstack.org/openstack/heat
 heat_git_install_branch: master

handlers/main.yml

@@ -19,8 +19,7 @@
     - Restart heat services
 
 - name: Reload upstart init scripts
-  shell: |
-    initctl reload-configuration
+  command: initctl reload-configuration
   notify:
     - Restart heat services
 

tasks/heat_db_setup.yml

@@ -17,3 +17,4 @@
   command: "{{ heat_bin }}/heat-manage db_sync"
   become: yes
   become_user: "{{ heat_system_user_name }}"
+  changed_when: false

tasks/heat_install.yml

@@ -53,7 +53,7 @@
 - name: Install requires pip packages
   pip:
     name: "{{ heat_requires_pip_packages | join(' ') }}"
-    state: latest
+    state: "{{ heat_pip_package_state }}"
     extra_args: "{{ pip_install_options_fact }}"
   register: install_packages
   until: install_packages|success
@@ -123,7 +123,7 @@
 - name: Install pip packages
   pip:
     name: "{{ heat_pip_packages | join(' ') }}"
-    state: latest
+    state: "{{ heat_pip_package_state }}"
     virtualenv: "{{ heat_bin | dirname }}"
     virtualenv_site_packages: "no"
     extra_args: "{{ pip_install_options_fact }}"

tasks/main.yml

@@ -34,6 +34,7 @@
 
 - name: Check init system
   command: cat /proc/1/comm
+  changed_when: false
   register: _pid1_name
   tags:
     - always