From 2a28918663090cc98ebaab7836e048e83b422808 Mon Sep 17 00:00:00 2001 From: Jesse Pretorius Date: Tue, 2 Aug 2016 14:37:27 +0100 Subject: [PATCH] Add ability to change apt/yum package state The current method of installing the distribution packages required is set in the tasks and cannot be changed by a deployer. Currently the apt task always installs the latest package. This results in unexpected binary changes when a deployer may simply be trying to execute a configuration change. This patch adds the ability for a deployer to change the desired state so that the results are predictable. Change-Id: I16a81da2b61cd69bafc59ac113fe546a748e8675 --- defaults/main.yml | 4 ++++ .../notes/package-state-2e8e2eb4b24475c4.yaml | 13 +++++++++++++ tasks/ironic_install_apt.yml | 2 +- 3 files changed, 18 insertions(+), 1 deletion(-) create mode 100644 releasenotes/notes/package-state-2e8e2eb4b24475c4.yaml diff --git a/defaults/main.yml b/defaults/main.yml index 97d95020..40cbe7ee 100644 --- a/defaults/main.yml +++ b/defaults/main.yml @@ -18,6 +18,10 @@ # Verbosity Options debug: False +# Set the package install state for distribution packages +# Options are 'present' and 'latest' +ironic_package_state: "latest" + # These variables are used in 'developer mode' in order to allow the role # to build an environment directly from a git source without the presence # of an OpenStack-Ansible repo_server. diff --git a/releasenotes/notes/package-state-2e8e2eb4b24475c4.yaml b/releasenotes/notes/package-state-2e8e2eb4b24475c4.yaml new file mode 100644 index 00000000..637a1607 --- /dev/null +++ b/releasenotes/notes/package-state-2e8e2eb4b24475c4.yaml @@ -0,0 +1,13 @@ +--- +features: + - The os_ironic role now supports the ability to configure whether + apt/yum tasks install the latest available package, or just ensure + that the package is present. The default action is to ensure that + the latest package is present. The action taken may be changed to + only ensure that the package is present by setting + ``ironic_package_state`` to ``present``. +upgrade: + - The os_ironic role always checks whether the latest package is + installed when executed. If a deployer wishes to change the check to + only validate the presence of the package, the option + ``ironic_package_state`` should be set to ``present``. diff --git a/tasks/ironic_install_apt.yml b/tasks/ironic_install_apt.yml index 5525d39d..c629de57 100644 --- a/tasks/ironic_install_apt.yml +++ b/tasks/ironic_install_apt.yml @@ -27,7 +27,7 @@ - name: Install apt packages apt: pkg: "{{ item }}" - state: latest + state: "{{ ironic_package_state }}" register: install_packages until: install_packages|success retries: 5