From 06d7fb54c5c8fdfef7fbead83e8a47c41cda575e Mon Sep 17 00:00:00 2001 From: Jimmy McCrory Date: Wed, 18 May 2016 20:42:33 -0700 Subject: [PATCH] Use ansible-lint 2.7.0 ansible-lint 2.7.0 was recently released, update the role's test requirements to use it. The tox test has been changed to run ansible-lint against this role, rather than the test playbook which would only apply to this role's dependencies. Also update the 'Drop fernet key auto rotate script' task to use mode "0755", matching the comment above the task and to resolve a violation of new rule, [ANSIBLE0009] Octal file permissions must contain leading zero. Change-Id: I09396f8938cf8f0b5d48bc5b7215ecea2c426e94 --- tasks/keystone_fernet_keys_autorotate.yml | 2 +- test-requirements.txt | 2 +- tox.ini | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tasks/keystone_fernet_keys_autorotate.yml b/tasks/keystone_fernet_keys_autorotate.yml index 22086eae..18a1cad7 100644 --- a/tasks/keystone_fernet_keys_autorotate.yml +++ b/tasks/keystone_fernet_keys_autorotate.yml @@ -24,7 +24,7 @@ dest: "{{ keystone_fernet_auto_rotation_script }}" owner: "{{ keystone_system_user_name }}" group: "{{ keystone_system_group_name }}" - mode: "1755" + mode: "0755" tags: - keystone-fernet-auto-rotate diff --git a/test-requirements.txt b/test-requirements.txt index a6cce405..fb9592f2 100644 --- a/test-requirements.txt +++ b/test-requirements.txt @@ -1,4 +1,4 @@ -ansible-lint<=2.3.9 +ansible-lint>=2.7.0,<3.0.0 ansible>=1.9.1,<2.0.0,!=1.9.6 bashate flake8 diff --git a/tox.ini b/tox.ini index 96cb0f1f..799113dd 100644 --- a/tox.ini +++ b/tox.ini @@ -101,7 +101,7 @@ commands = [testenv:ansible-lint] commands = - ansible-lint {toxinidir}/tests/test.yml + ansible-lint {toxinidir} [testenv:functional]