openstack
/
openstack-ansible-os_keystone
Code Issues Proposed changes

Remove unnecessary package install duplication 

Currently the devel packages are installed everywhere,
but they only need to be where the wheels are built.

Also, there is already a task to install the packages
needed on the target hosts when installing - so we do
not need to give the same list to the venv install role
because they will already have been installed.

Change-Id: I306017d66416f147a17ae9e1f16130af4bfa7774
This commit is contained in:
Jesse Pretorius 2018-10-30 19:24:12 +00:00
parent 6f8dca7f7d
commit af8985d884
2 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
tasks/keystone_install_source.yml
View File

@ -41,7 +41,6 @@
vars:
venv_build_distro_package_list: "{{ keystone_devel_distro_packages }}"
venv_install_destination_path: "{{ keystone_bin | dirname }}"
venv_install_distro_package_list: "{{ keystone_distro_packages }}"
venv_pip_install_args: "{{ keystone_pip_install_args }}"
venv_pip_packages: >-
{{ keystone_pip_packages +

4
vars/source_install.yml
View File

@ -31,13 +31,9 @@ keystone_package_list: |-
{% else %}
{% set _ = packages.extend(keystone_nginx_distro_packages) %}
{% endif %}
{% if keystone_developer_mode | bool %}
{% set _ = packages.extend(keystone_developer_mode_distro_packages) %}
{% endif %}
{% if keystone_oslomsg_amqp1_enabled | bool %}
{% set _ = packages.extend(keystone_oslomsg_amqp1_distro_packages) %}
{% endif %}
{% set _ = packages.extend(keystone_devel_distro_packages) %}
{{ packages }}
_keystone_bin: "/openstack/venvs/keystone-{{ keystone_venv_tag }}/bin"