Rename Masakari service type

Project documentation suggests Masakari to have `instance-ha` service
type, which is good to align on. Other deployment tools do use that
service type as well.

Depends-On: https://review.opendev.org/c/openstack/openstack-ansible-openstack_hosts/+/930272
Change-Id: Icdc07fbba1a0768ebb706847d5f4b426ec3c315c

defaults/main.yml

@@ -116,7 +116,7 @@ masakari_service_registry_proto: "{{ masakari_service_proto }}"
 masakari_service_publicuri_proto: "{{ openstack_service_publicuri_proto | default(masakari_service_proto) }}"
 masakari_service_adminuri_proto: "{{ openstack_service_adminuri_proto | default(masakari_service_proto) }}"
 masakari_service_internaluri_proto: "{{ openstack_service_internaluri_proto | default(masakari_service_proto) }}"
-masakari_service_type: ha
+masakari_service_type: instance-ha
 masakari_service_description: "Masakari ha Service"
 masakari_service_user_name: masakari
 masakari_service_project_name: service

releasenotes/notes/masakari_service_type_rename-4a86255372f8a3b5.yaml

@@ -0,0 +1,5 @@
+---
+upgrade:
+  - |
+    Service type in catalog has been changed from ``ha`` to ``instance-ha``
+    in order to align service types with `service deployment guide <https://docs.openstack.org/masakari/latest/install/install_and_configure_ubuntu.html>`_

tasks/main.yml

@@ -196,6 +196,10 @@
       - name: "{{ masakari_service_name }}"
         type: "{{ masakari_service_type }}"
         description: "{{ masakari_service_description }}"
+      # TODO(noonedeadpunk): Remove after Epoxy release
+      - name: "{{ masakari_service_name }}"
+        type: "ha"
+        state: absent
   when:
     - "_masakari_is_first_play_host"
   tags: