Fix linting issues for ansible-lint 3.4.1

Preparing this role for the ansible-lint version bump

Change-Id: I8bfa56de4f69f121cdec419d3135153dc26edfbd

defaults/main.yml

@@ -16,7 +16,7 @@
 # (c) 2016 Donovan Francesco <donovan.francesco@is.co.za>
 # (c) 2016 Paul Stevens <paul.stevens@is.co.za>
 monasca_package_state: "latest"
-
+monasca_pip_package_state: "latest"
 debug: false
 
 ## System info

handlers/main.yml

@@ -22,8 +22,7 @@
     - Restart monasca services
 
 - name: Reload upstart init scripts
-  shell: |
+  command: initctl reload-configuration
-    initctl reload-configuration
   notify:
     - Restart monasca services
 

meta/main.yml

@@ -42,9 +42,15 @@ dependencies:
   - role: apt_package_pinning
     when:
       - ansible_pkg_mgr == 'apt'
-  - ansible-zookeeper
+  - role: ansible-zookeeper
-  - ansible-kafka
+    tags: skip_ansible_lint
-  - ansible-storm
+  - role: ansible-kafka
-  - ansible-influxdb
+    tags: skip_ansible_lint
-  - ansible-grafana
+  - role: ansible-storm
-  - ansible-monasca-schema
+    tags: skip_ansible_lint
+  - role: ansible-influxdb
+    tags: skip_ansible_lint
+  - role: ansible-grafana
+    tags: skip_ansible_lint
+  - role: ansible-monasca-schema
+    tags: skip_ansible_lint

tasks/install.yml

@@ -68,7 +68,7 @@
 - name: Install requires pip packages
   pip:
     name: "{{ monasca_requires_pip_packages | join(' ') }}"
-    state: latest
+    state: "{{ monasca_pip_package_state }}"
     extra_args: "{{ pip_install_options_fact }}"
   register: install_packages
   until: install_packages|success
@@ -139,7 +139,7 @@
 - name: Install pip packages
   pip:
     name: "{{ monasca_pip_packages | join(' ') }}"
-    state: latest
+    state: "{{ monasca_pip_package_state }}"
     virtualenv: "{{ monasca_bin | dirname }}"
     virtualenv_site_packages: "no"
     extra_args: "{{ pip_install_options_fact }}"

tasks/main.yml

@@ -29,6 +29,7 @@
 
 - name: Check init system
   command: cat /proc/1/comm
+  changed_when: false
   register: _pid1_name
   tags:
     - always

tasks/pre-install.yml

@@ -26,7 +26,7 @@
 - name: Install Apt dependencies
   apt:
     pkg: "{{ item }}"
-    state: "latest"
+    state: "{{ monasca_package_state }}"
   register: install_deps
   until: install_deps | success
   retries: 5