Updated multi-distro setup for isolation

The changes here update the multi-distro framework within os_neutron
to isolate package variables and init systems which will pave the way
for additional OS support.

Change-Id: Id6c15220bbd4120d525147d02aaf15c0f47e49e6
Signed-off-by: Kevin Carter <kevin.carter@rackspace.com>

defaults/main.yml

@@ -405,29 +405,6 @@ neutron_service_in_ldap: false
 # neutron_local_ip is used for the VXLAN local tunnel endpoint
 neutron_local_ip: 127.0.0.1
 
-neutron_apt_packages:
-  - conntrack
-  - dnsmasq-base
-  - dnsmasq-utils
-  - ebtables
-  - ipset
-  - iputils-arping
-  - keepalived
-  - libpq-dev
-  - radvd
-
-neutron_lxb_apt_packages:
-  - bridge-utils
-
-neutron_lbaas_apt_packages:
-  - haproxy
-
-neutron_vpnaas_apt_packages:
-  - openswan
-
-neutron_apt_remove_packages:
-  - conntrackd
-
 # neutron packages that must be installed before anything else
 neutron_requires_pip_packages:
   - virtualenv

tasks/main.yml

@@ -24,6 +24,18 @@
   tags:
     - always
 
+- name: Check init system
+  command: cat /proc/1/comm
+  register: _pid1_name
+  tags:
+    - always
+
+- name: Set the name of pid1
+  set_fact:
+    pid1_name: "{{ _pid1_name.stdout }}"
+  tags:
+    - always
+
 - include: ovs_install.yml
   when:
     - neutron_services['neutron-openvswitch-agent']['group'] in group_names

tasks/neutron_init_common.yml

@@ -14,16 +14,12 @@
 # limitations under the License.
 
 - include: neutron_init_upstart.yml
-  when:
+  when: pid1_name == "init"
-    - ansible_distribution | lower == 'ubuntu'
-    - ansible_distribution_version | version_compare('16.04', '<')
   tags:
     - neutron-init
 
 - include: neutron_init_systemd.yml
-  when:
+  when: pid1_name == "systemd"
-    - ansible_distribution | lower == 'ubuntu'
-    - ansible_distribution_version | version_compare('16.04', '>=')
   tags:
     - neutron-init
 

vars/ubuntu-14.04.yml

@@ -33,13 +33,30 @@ neutron_apt_dependencies:
   - libpq-dev
   - radvd
 
+neutron_apt_packages:
+  - conntrack
+  - dnsmasq-base
+  - dnsmasq-utils
+  - ebtables
+  - ipset
+  - iputils-arping
+  - keepalived
+  - libpq-dev
+  - radvd
+
+neutron_lxb_apt_packages:
+  - bridge-utils
+
 neutron_lbaas_apt_packages:
   - haproxy
 
+neutron_vpnaas_apt_packages:
+  - openswan
+
 neutron_apt_remove_packages:
   - conntrackd
 
 neutron_lbaasv1_initscript_path: "/etc/init/neutron-lbaas-agent.conf"
 neutron_lbaasv2_initscript_path: "/etc/init/neutron-lbaasv2-agent.conf"
 neutron_lbaasv1_agent_servicename: "neutron-lbaas-agent"
-neutron_lbaasv2_agent_servicename: "neutron-lbaasv2-agent"
+neutron_lbaasv2_agent_servicename: "neutron-lbaasv2-agent"

vars/ubuntu-16.04.yml

@@ -35,13 +35,30 @@ neutron_apt_dependencies:
   - libpq-dev
   - radvd
 
+neutron_apt_packages:
+  - conntrack
+  - dnsmasq-base
+  - dnsmasq-utils
+  - ebtables
+  - ipset
+  - iputils-arping
+  - keepalived
+  - libpq-dev
+  - radvd
+
+neutron_lxb_apt_packages:
+  - bridge-utils
+
 neutron_lbaas_apt_packages:
   - haproxy
 
+neutron_vpnaas_apt_packages:
+  - openswan
+
 neutron_apt_remove_packages:
   - conntrackd
 
 neutron_lbaasv1_initscript_path: "/etc/init/neutron-lbaas-agent.conf"
 neutron_lbaasv2_initscript_path: "/etc/init/neutron-lbaasv2-agent.conf"
 neutron_lbaasv1_agent_servicename: "neutron-lbaas-agent"
-neutron_lbaasv2_agent_servicename: "neutron-lbaasv2-agent"
+neutron_lbaasv2_agent_servicename: "neutron-lbaasv2-agent"