openstack/openstack-ansible-os_nova
Code Issues Proposed changes

Deprecate nova_ram_weight_multiplier

Browse Source 
Long time ago a variable `nova_ram_weight_multiplier` was implemented
and its default value was set to 5.0.
There are 2 issues with this:
1. Default value in nova is 1.0 [1] so our value is much bigger than
nova's default without having a strong reason for that.
2. OSA does not provide similar variables for other multipliers like
`cpu_weight_multiplier`.

Because there are a couple of different multipliers and more of them
can be implemented in the future(for ex.
`hypervisor_version_weight_multiplier` was implemented in 2023.2) it
would be hard for the OSA project to maintain variables for all of them.
It is better to deprecate `nova_ram_weight_multiplier` and let users
define multipliers with `nova_nova_conf_overrides` if necessary.

[1] https://docs.openstack.org/nova/2023.1/configuration/config.html#filter_scheduler.ram_weight_multiplier

Change-Id: I4f82840e94312d38696e3ddd05ef494821233f4d
This commit is contained in:
Damian Dabrowski 2023-07-11 21:35:41 +02:00
parent c90a5c2b92
commit 7000bc3f3f
3 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
defaults/main.yml
View File

@ -317,7 +317,6 @@ nova_cpu_allocation_ratio: 2.0
nova_disk_allocation_ratio: 1.0
nova_max_io_ops_per_host: 10
nova_ram_allocation_ratio: 1.0
nova_ram_weight_multiplier: 5.0
nova_reserved_host_disk_mb: 2048
nova_scheduler_host_subset_size: "{{ ((((groups['compute_hosts'] | default([]) | length) * 0.3) | round | int, 10) | min, 1) | max }}"

8
releasenotes/notes/nova_ram_weight_multiplier_deprecation-1b152707b4737b3c.yaml Normal file
View File

@ -0,0 +1,8 @@
---
deprecations:
- |
``nova_ram_weight_multiplier`` was deprecated. Multipliers should be
defined using ``nova_nova_conf_overrides``.
Please note that default value for ``nova_ram_weight_multiplier`` was
previously set to 5, while nova default is 1. This deprecation will
slightly change weighing behavior in OSA.

1
templates/nova.conf.j2
View File

@ -325,7 +325,6 @@ discover_hosts_in_cells_interval = {{ nova_discover_hosts_in_cells_interval }}
[filter_scheduler]
max_io_ops_per_host = {{ nova_max_io_ops_per_host }}
ram_weight_multiplier = {{ nova_ram_weight_multiplier }}
enabled_filters = {{ _nova_scheduler_filters | join(',') }}
host_subset_size = {{ nova_scheduler_host_subset_size }}
track_instance_changes = {{ nova_scheduler_tracks_instance_changes }}