openstack/openstack-ansible-os_nova
Code Issues Proposed changes

Use nova_management_address as a default VNC bind address

Browse Source 
Our installation uses separate networks for deployment and
OpenStack management. The current default of 'ansible_host' for
the VNC server results in it binding to our deployment network.

Whilst this could be resolved via variable overrides, the majority
of the defaults and templated options in this role use the Nova
management address as the default choice for binding to.

This patch changes the default VNC bind address to match the
existing standard pattern, which should avoid the need for
overrides in most cases. As a result, for our setup, when
nova_management_address is identified and set in the OSA nova
playbooks to match the OpenStack management network, the VNC server
bind address gets set to the correct address.

Change-Id: I9c5e2584f8f1d9bd76120b8b236e25f63804473a
This commit is contained in:
Andrew Bonney
2020-07-15 11:11:39 +01:00
committed by Jonathan Rosser
parent cd85105f3b
commit 9da99e1f7c
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
defaults/main.yml
View File

@@ -218,8 +218,8 @@ nova_novncproxy_proto: "{{ openstack_service_publicuri_proto | default('http') }
nova_novncproxy_port: 6080 nova_novncproxy_port: 6080
nova_novncproxy_base_uri: "{{ nova_novncproxy_proto }}://{{ external_lb_vip_address }}:{{ nova_novncproxy_port }}" nova_novncproxy_base_uri: "{{ nova_novncproxy_proto }}://{{ external_lb_vip_address }}:{{ nova_novncproxy_port }}"
nova_novncproxy_base_url: "{{ nova_novncproxy_base_uri }}/vnc_lite.html" nova_novncproxy_base_url: "{{ nova_novncproxy_base_uri }}/vnc_lite.html"
nova_novncproxy_vncserver_proxyclient_address: "{{ ansible_host }}" nova_novncproxy_vncserver_proxyclient_address: "{{ (nova_management_address == 'localhost') | ternary('127.0.0.1', nova_management_address) }}"
nova_novncproxy_vncserver_listen: "{{ ansible_host }}" nova_novncproxy_vncserver_listen: "{{ (nova_management_address == 'localhost') | ternary('127.0.0.1', nova_management_address) }}"
nova_novncproxy_agent_enabled: True nova_novncproxy_agent_enabled: True
nova_novncproxy_git_repo: "{{ novncproxy_git_repo | default('https://github.com/novnc/noVNC') }}" nova_novncproxy_git_repo: "{{ novncproxy_git_repo | default('https://github.com/novnc/noVNC') }}"
nova_novncproxy_git_install_branch: "{{ novncproxy_git_install_branch | default('master') }}" nova_novncproxy_git_install_branch: "{{ novncproxy_git_install_branch | default('master') }}"