openstack/openstack-ansible-os_nova
Code Issues Proposed changes

Update patch set 2

Browse Source 
Patch Set 2: Code-Review+1

(1 comment)

Patch-set: 2
Reviewer: Gerrit User 28619 <28619@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1, 4fd67d3ef851a7640cd745e02eaaa6a11296a766
Attention: {"person_ident":"Gerrit User 35983 \u003c35983@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_28619\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 28619 \u003c28619@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_28619\u003e replied on the change"}
This commit is contained in:
Gerrit User 28619 2024-03-14 15:27:50 +00:00 committed by Gerrit Code Review
parent b58028c713
commit badf5fff70
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
d2004fffb3734f52f5249d84dd2bfff852370d15
View File

@ -64,6 +64,30 @@
"revId": "d2004fffb3734f52f5249d84dd2bfff852370d15",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "306cc076_6cafa3d7",
"filename": "tasks/drivers/kvm/nova_compute_kvm.yml",
"patchSetId": 1
},
"lineNbr": 140,
"author": {
"id": 28619
},
"writtenOn": "2024-03-14T15:27:50Z",
"side": 1,
"message": "Hm, maybe `blockinfile` then?\n\nI mean - there\u0027re other legit usecases when you want to modify `usr.lib.libvirt.virt-aa-helper` so it would make sense to me at least to have a variable that allows you to define an extra content to apparmor profile",
"parentUuid": "b4c94da5_ed3e309b",
"range": {
"startLine": 140,
"startChar": 11,
"endLine": 140,
"endChar": 57
},
"revId": "d2004fffb3734f52f5249d84dd2bfff852370d15",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {