openstack/openstack-ansible-os_nova
Code Issues Proposed changes

pre-install: use path and drop dest

Browse Source 
We have a few checks that depend on the value of path and
dest is an alias of path anyways so we should just always
use path instead.

Change-Id: I38ed2b120ece1268ccfe519c94bda038571a99b7
This commit is contained in:
Mohammed Naser
2020-02-05 08:20:07 +01:00
parent e72835e5ac
commit bbbbd94101
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
tasks/nova_pre_install.yml
View File

@@ -84,9 +84,8 @@
- name: Create nova dir - name: Create nova dir
file: file:
path: "{{ item.path | default(omit) }}" path: "{{ item.path }}"
src: "{{ item.src | default(omit) }}" src: "{{ item.src | default(omit) }}"
dest: "{{ item.dest | default(omit) }}"
state: "{{ item.state | default('directory') }}" state: "{{ item.state | default('directory') }}"
owner: "{{ item.owner|default(nova_system_user_name) }}" owner: "{{ item.owner|default(nova_system_user_name) }}"
group: "{{ item.group|default(nova_system_group_name) }}" group: "{{ item.group|default(nova_system_group_name) }}"
@@ -104,7 +103,7 @@
# NOTE(cloudnull): The "src" path is relative. This ensures all files remain # NOTE(cloudnull): The "src" path is relative. This ensures all files remain
# within the host/container confines when connecting to # within the host/container confines when connecting to
# them using the connection plugin or the root filesystem. # them using the connection plugin or the root filesystem.
- dest: "/etc/nova" - path: "/etc/nova"
src: "{{ nova_bin | dirname | regex_replace('^/', '../') }}/etc/nova" src: "{{ nova_bin | dirname | regex_replace('^/', '../') }}/etc/nova"
state: link state: link
force: true force: true