badf5fff70
Patch Set 2: Code-Review+1
(1 comment)
Patch-set: 2
Reviewer: Gerrit User 28619 <28619@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=+1, 4fd67d3ef851a7640cd745e02eaaa6a11296a766
Attention: {"person_ident":"Gerrit User 35983 \u003c35983@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_28619\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 28619 \u003c28619@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_28619\u003e replied on the change"}
115 lines
3.8 KiB
Plaintext
115 lines
3.8 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "1420622b_7437d14e",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 28619
|
|
},
|
|
"writtenOn": "2024-03-12T17:00:33Z",
|
|
"side": 1,
|
|
"message": "I guess I\u0027d suggest adding a new variable, that would make possible to manage the overrides for `usr.lib.libvirt.virt-aa-helper`, as I\u0027d had a usecase back in the days to add an NFS mount to allowed path as well, ie `/var/lib/nova/mnt/** rk`",
|
|
"revId": "d2004fffb3734f52f5249d84dd2bfff852370d15",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "bfb327df_e05abdbf",
|
|
"filename": "tasks/drivers/kvm/nova_compute_kvm.yml",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 140,
|
|
"author": {
|
|
"id": 28619
|
|
},
|
|
"writtenOn": "2024-03-12T17:00:33Z",
|
|
"side": 1,
|
|
"message": "I think it should be `/etc/apparmor.d/local/usr.lib.libvirt.virt-aa-helper` for leveraging local overrides mechanism.\n\nIt should take precedence over the default rules file.\n\nAlso then I\u0027m not sure if should be lineinfile or just some copy with content. As to proper insure idempotency you;\u0027d need to fetch content and ensure that `/var/lib/nova` is not there.",
|
|
"range": {
|
|
"startLine": 140,
|
|
"startChar": 11,
|
|
"endLine": 140,
|
|
"endChar": 57
|
|
},
|
|
"revId": "d2004fffb3734f52f5249d84dd2bfff852370d15",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "b4c94da5_ed3e309b",
|
|
"filename": "tasks/drivers/kvm/nova_compute_kvm.yml",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 140,
|
|
"author": {
|
|
"id": 35983
|
|
},
|
|
"writtenOn": "2024-03-14T14:07:10Z",
|
|
"side": 1,
|
|
"message": "I suppose lineinfile is ok in case of utilising /etc/apparmor.d/local/usr.lib.libvirt.virt-aa-helper\nThat should allow left intact possible customisations and ensure that our line is there anyway.",
|
|
"parentUuid": "bfb327df_e05abdbf",
|
|
"range": {
|
|
"startLine": 140,
|
|
"startChar": 11,
|
|
"endLine": 140,
|
|
"endChar": 57
|
|
},
|
|
"revId": "d2004fffb3734f52f5249d84dd2bfff852370d15",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "306cc076_6cafa3d7",
|
|
"filename": "tasks/drivers/kvm/nova_compute_kvm.yml",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 140,
|
|
"author": {
|
|
"id": 28619
|
|
},
|
|
"writtenOn": "2024-03-14T15:27:50Z",
|
|
"side": 1,
|
|
"message": "Hm, maybe `blockinfile` then?\n\nI mean - there\u0027re other legit usecases when you want to modify `usr.lib.libvirt.virt-aa-helper` so it would make sense to me at least to have a variable that allows you to define an extra content to apparmor profile",
|
|
"parentUuid": "b4c94da5_ed3e309b",
|
|
"range": {
|
|
"startLine": 140,
|
|
"startChar": 11,
|
|
"endLine": 140,
|
|
"endChar": 57
|
|
},
|
|
"revId": "d2004fffb3734f52f5249d84dd2bfff852370d15",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "44a214e7_fc148a7f",
|
|
"filename": "tasks/drivers/kvm/nova_compute_kvm.yml",
|
|
"patchSetId": 1
|
|
},
|
|
"lineNbr": 141,
|
|
"author": {
|
|
"id": 28619
|
|
},
|
|
"writtenOn": "2024-03-12T17:02:07Z",
|
|
"side": 1,
|
|
"message": "`nova_system_home_folder`",
|
|
"range": {
|
|
"startLine": 141,
|
|
"startChar": 16,
|
|
"endLine": 141,
|
|
"endChar": 25
|
|
},
|
|
"revId": "d2004fffb3734f52f5249d84dd2bfff852370d15",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |