fe537c7a29
If apt_repository fails to update the apt cache after updating the configuration, retries don't register there was a change and so no attempt is made to update the cache by the module on the second attempt. This failure can result in a failure to install packages. This change adds an apt module task to update the cache if the apt_repository task registers a change. This means updating the cache will get retried on failure and no longer fail silently. Change-Id: I1d71deeee64fe27df1275965aac8240cc2ab427c Partial-Bug: #1750656
55 lines
1.6 KiB
YAML
55 lines
1.6 KiB
YAML
---
|
|
# Copyright 2017, IBM Corp.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
- name: Add novalink keys
|
|
apt_key:
|
|
url: "{{ item.url }}"
|
|
state: "{{ item.state }}"
|
|
register: add_nv_keys
|
|
until: add_nv_keys|success
|
|
retries: 5
|
|
delay: 2
|
|
with_items: "{{ novalink_gpg_keys }}"
|
|
tags:
|
|
- novalink-apt-keys
|
|
|
|
# When updating the cache in the apt_repository
|
|
# task, and the update fails, a retry does not
|
|
# detect a change the second attempt and therefore
|
|
# does not update the cache, resulting in a changed
|
|
# repo config, but no updated cache. To work around
|
|
# this bug we implement the change of repo config
|
|
# and the cache update as two seperate tasks.
|
|
- name: Add novalink repo
|
|
apt_repository:
|
|
repo: "{{ novalink_repo.repo }}"
|
|
state: "{{ novalink_repo.state }}"
|
|
filename: "{{ novalink_repo.filename | default(omit) }}"
|
|
update_cache: no
|
|
register: add_nv_repos
|
|
tags:
|
|
- novalink-repo
|
|
|
|
- name: Update Apt cache
|
|
apt:
|
|
update_cache: yes
|
|
when: add_nv_repos | changed
|
|
register: update_apt_cache
|
|
until: update_apt_cache | success
|
|
retries: 5
|
|
delay: 2
|
|
tags:
|
|
- novalink-repo
|