openstack
/
openstack-ansible-os_octavia
Code Issues Proposed changes

Update patch set 9 

Patch Set 9: Code-Review-1

(1 comment)

Patch-set: 9
Reviewer: Gerrit User 25023 <25023@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, 57e3d71eeb1571a2591cbdff951692af2e709632
Attention: {"person_ident":"Gerrit User 28619 \u003c28619@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_25023\u003e replied on the change"}
This commit is contained in:
Gerrit User 25023 2023-05-23 08:55:48 +00:00 committed by Gerrit Code Review
parent eb9023eafc
commit 06d70741b9
1 changed files with 23 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
5eae150e00ea9a080401f9596fcb5841b5f1e01f
View File

@ -16,6 +16,29 @@
"message": "I think we can land that and iterate over, as overall it looks okeyish, despite I don\u0027t really like reffering `neutron_` vars as is.",
"revId": "5eae150e00ea9a080401f9596fcb5841b5f1e01f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "f53e0410_228c9ff9",
"filename": "defaults/main.yml",
"patchSetId": 9
},
"lineNbr": 329,
"author": {
"id": 25023
},
"writtenOn": "2023-05-23T08:55:48Z",
"side": 1,
"message": "this is going to re-use the certificate created by os_neutron for a metal deploy where ansible_facts[\u0027hostname\u0027] is the same for neutron/octavia.\n\nI think it is best to namespace the variables and certificates correctly otherwise this is going to be pretty confusing.",
"range": {
"startLine": 329,
"startChar": 4,
"endLine": 329,
"endChar": 8
},
"revId": "5eae150e00ea9a080401f9596fcb5841b5f1e01f",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}