Update patch set 1
Patch Set 1: Code-Review-1 (2 comments) Patch-set: 1 Label: Code-Review=-1
This commit is contained in:
parent
5c8c016235
commit
fe2f6e7b14
|
@ -0,0 +1,50 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fad55976_f18c0881",
|
||||
"filename": "templates/sahara.conf.j2",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 74,
|
||||
"author": {
|
||||
"id": 6816
|
||||
},
|
||||
"writtenOn": "2016-07-16T18:53:51Z",
|
||||
"side": 1,
|
||||
"message": "Missing underscores.",
|
||||
"range": {
|
||||
"startLine": 73,
|
||||
"startChar": 0,
|
||||
"endLine": 74,
|
||||
"endChar": 39
|
||||
},
|
||||
"revId": "1480e3ac0e633366ed9793418dee2d77f5cc49f1",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "fad55976_11c0bc7a",
|
||||
"filename": "tests/test-vars.yml",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 102,
|
||||
"author": {
|
||||
"id": 6816
|
||||
},
|
||||
"writtenOn": "2016-07-16T18:53:51Z",
|
||||
"side": 1,
|
||||
"message": "This var has no role defaults, so this patch should include a set of defaults - even if they\u0027re only nominal.",
|
||||
"range": {
|
||||
"startLine": 102,
|
||||
"startChar": 0,
|
||||
"endLine": 102,
|
||||
"endChar": 37
|
||||
},
|
||||
"revId": "1480e3ac0e633366ed9793418dee2d77f5cc49f1",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue