diff --git a/defaults/main.yml b/defaults/main.yml index 127f9ba5..54d2aee7 100644 --- a/defaults/main.yml +++ b/defaults/main.yml @@ -47,8 +47,19 @@ swift_developer_constraints: - "git+{{ swift_git_repo }}@{{ swift_git_install_branch }}#egg=swift" - "git+{{ swift_swift3_git_repo }}@{{ swift_swift3_git_install_branch }}#egg=swift3" +# TODO(odyssey4me): +# This can be simplified once all the roles are using +# python_venv_build. We can then switch to using a +# set of constraints in pip.conf inside the venv, +# perhaps prepared by giving a giving a list of +# constraints to the role. +swift_pip_install_args: >- + {{ swift_developer_mode | ternary(pip_install_developer_constraints | default('--constraint /opt/developer-pip-constraints.txt'), '') }} + {{ (pip_install_upper_constraints is defined) | ternary('--constraint ' + pip_install_upper_constraints | default(''), '') }} + {{ pip_install_options | default('') }} + # Name of the virtual env to deploy into -swift_venv_tag: untagged +swift_venv_tag: "{{ venv_tag | default('untagged') }}" swift_bin: "{{ _swift_bin }}" # venv_download, even when true, will use the fallback method of building the diff --git a/handlers/main.yml b/handlers/main.yml index a3a4437a..39347242 100644 --- a/handlers/main.yml +++ b/handlers/main.yml @@ -20,6 +20,8 @@ state: "restarted" daemon_reload: yes with_items: "{{ filtered_swift_services }}" + listen: + - "venv changed" - name: Restart rsyslog service: diff --git a/tasks/swift_install_source.yml b/tasks/swift_install_source.yml index 6727427c..a46ee41e 100644 --- a/tasks/swift_install_source.yml +++ b/tasks/swift_install_source.yml @@ -13,6 +13,12 @@ # See the License for the specific language governing permissions and # limitations under the License. +# TODO(odyssey4me): +# This can be simplified once all the roles are using +# python_venv_build. We can then switch to using a +# set of constraints in pip.conf inside the venv, +# perhaps prepared by giving a giving a list of +# constraints to the role. - name: Create developer mode constraint file copy: dest: "/opt/developer-pip-constraints.txt" @@ -23,93 +29,22 @@ when: - swift_developer_mode | bool -- name: Retrieve checksum for venv download - uri: - url: "{{ swift_venv_download_url | replace('tgz', 'checksum') }}" - return_content: yes - register: swift_venv_checksum - when: swift_venv_download | bool - -- name: Attempt venv download - get_url: - url: "{{ swift_venv_download_url }}" - dest: "/var/cache/{{ swift_venv_download_url | basename }}" - checksum: "sha1:{{ swift_venv_checksum.content | trim }}" - register: swift_get_venv - when: swift_venv_download | bool - -- name: Remove existing venv - file: - path: "{{ swift_bin | dirname }}" - state: absent - when: swift_get_venv is changed - -- name: Create swift venv dir - file: - path: "{{ swift_bin | dirname }}" - state: directory - mode: "0755" - register: swift_venv_dir - when: swift_get_venv is changed - -- name: Unarchive pre-built venv - unarchive: - src: "/var/cache/{{ swift_venv_download_url | basename }}" - dest: "{{ swift_bin | dirname }}" - copy: "no" - when: swift_get_venv is changed - notify: - - Restart swift services - -- name: Install pip packages - pip: - name: "{{ swift_pip_packages }}" - state: "{{ swift_pip_package_state }}" - virtualenv: "{{ swift_bin | dirname }}" - virtualenv_site_packages: "no" - extra_args: >- - {{ swift_developer_mode | ternary(pip_install_developer_constraints | default('--constraint /opt/developer-pip-constraints.txt'), '') }} - {{ (pip_install_upper_constraints is defined) | ternary('--constraint ' + pip_install_upper_constraints | default(''),'') }} - {{ pip_install_options | default('') }} - register: install_packages - until: install_packages is success - retries: 5 - delay: 2 - when: swift_get_venv | failed or swift_get_venv | skipped - notify: - - Restart swift services - -- name: Remove python from path first (CentOS, openSUSE) - file: - path: "{{ swift_bin | dirname }}/bin/python2.7" - state: "absent" +- name: Ensure remote wheel building is disabled in developer mode + set_fact: + venv_build_host: "{{ ansible_hostname }}" when: - - ansible_pkg_mgr in ['yum', 'dnf', 'zypper'] - - swift_get_venv is changed + - swift_developer_mode | bool -# NOTE(odyssey4me): -# We reinitialize the venv to ensure that the right -# version of python is in the venv, but we do not -# want virtualenv to also replace pip, setuptools -# and wheel so we tell it not to. -# We do not use --always-copy for CentOS/SuSE due -# to https://github.com/pypa/virtualenv/issues/565 -- name: Update virtualenv path - shell: | - find {{ swift_bin }} -name \*.pyc -delete - sed -si '1s/^.*python.*$/#!{{ swift_bin | replace ('/','\/') }}\/python/' {{ swift_bin }}/* - virtualenv {{ swift_bin | dirname }} \ - {{ (ansible_pkg_mgr == 'apt') | ternary('--always-copy', '') }} \ - --no-pip \ - --no-setuptools \ - --no-wheel - when: swift_get_venv is changed - tags: - - skip_ansible_lint - -- name: Record the venv tag deployed - ini_file: - dest: "/etc/ansible/facts.d/openstack_ansible.fact" - section: swift - option: venv_tag - value: "{{ swift_venv_tag }}" +- name: Install the python venv + include_role: + name: "python_venv_build" + private: yes + vars: + venv_install_destination_path: "{{ swift_bin | dirname }}" + venv_install_distro_package_list: "{{ swift_distro_packages }}" + venv_pip_install_args: "{{ swift_pip_install_args }}" + venv_pip_packages: "{{ swift_pip_packages }}" + venv_facts_when_changed: + - section: "swift" + option: "venv_tag" + value: "{{ swift_venv_tag }}"