openstack
/
openstack-ansible-os_tempest
Code Issues Proposed changes

Fix stackviz for failed tempest runs 

ansible block w/ error handling was incorrect: the first block
failed when tempest executed, then the second one (which creates
stackviz) never got executed.

It also includes in the block assertion to check if tempest
failed (this is actually redundant check, not really needed).

Change-Id: Ie99060fce29f35ced77efb7b29b8f5f6e37abbcd
Closes-Bug: #1905460
This commit is contained in:
Rafael Folco 2020-11-24 16:16:43 -03:00
parent 18f796ad6a
commit 49004fb05f
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
tasks/tempest_run.yml
View File

@ -119,7 +119,6 @@
changed_when: false
failed_when: false
- block:
# Copy module doesn't copy recursively with remote_src set to true
- name: Copy stackviz-html to home directory
shell: |
@ -129,6 +128,7 @@
tags:
# don't trigger ANSIBLE0013
- skip_ansible_lint
when: tempest_run_stackviz | bool
- name: Collecting data from tempest run
shell: |
@ -140,9 +140,9 @@
tags:
# don't trigger ANSIBLE0013
- skip_ansible_lint
when: tempest_run_stackviz | bool
when: tempest_run_stackviz | bool
- name: Fail if tempest tests did not succeed
assert:
that:
- "tempest_tests_run.rc == 0"
- name: Fail if tempest tests did not succeed
assert:
that:
- "tempest_tests_run.rc == 0"