Merge "Use new ansible package module to install distro packages."

tasks/trove_install.yml

@@ -16,9 +16,22 @@
 # (c) 2016 Donovan Francesco <donovan.francesco@is.co.za>
 # (c) 2016 Paul Stevens <paul.stevens@is.co.za>
 
-- include: trove_install_apt.yml
+- name: Ensure apt cache is up to date
-  static: no
+  apt:
-  when: ansible_pkg_mgr == 'apt'
+    update_cache: yes
+    cache_valid_time: "{{ cache_timeout }}"
+  when:
+    - ansible_pkg_mgr == 'apt'
+
+- name: Install distro packages
+  package:
+    name: "{{ item }}"
+    state: "{{ trove_package_state }}"
+  register: install_packages
+  until: install_packages|success
+  retries: 5
+  delay: 2
+  with_items: "{{ trove_distro_packages }}"
 
 - name: Create developer mode constraint file
   copy:

tasks/trove_install_apt.yml

@@ -1,29 +0,0 @@
----
-# Copyright 2016 Internet Solutions (Pty) Ltd
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#    http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-# (c) 2016 Donovan Francesco <donovan.francesco@is.co.za>
-# (c) 2016 Paul Stevens <paul.stevens@is.co.za>
-
-- name: Install apt packages
-  apt:
-    pkg: "{{ item }}"
-    state: "{{ trove_package_state }}"
-    update_cache: yes
-    cache_valid_time: "{{ cache_timeout }}"
-  register: install_packages
-  until: install_packages|success
-  retries: 5
-  delay: 2
-  with_items: "{{ trove_apt_packages }}"

vars/ubuntu-14.04.yml

@@ -17,7 +17,7 @@
 # (c) 2016 Paul Stevens <paul.stevens@is.co.za>
 cache_timeout: 600
 
-trove_apt_packages:
+trove_distro_packages:
   - apache2
   - apache2-utils
   - libapache2-mod-wsgi

vars/ubuntu-16.04.yml

@@ -17,7 +17,7 @@
 # (c) 2016 Paul Stevens <paul.stevens@is.co.za>
 cache_timeout: 600
 
-trove_apt_packages:
+trove_distro_packages:
   - apache2
   - apache2-utils
   - libapache2-mod-wsgi