Fix tests repo cloning

We have a script for doing the test repo cloning, we should use
it. The script is synchronized and works well with different
branches, where the tox.ini isn't synchronized, and therefore
can lag, like it is right now, in the branch upgrades.

Change-Id: Ibb94eb78a028b28e41591c1cd9ee582a225019dc

tox.ini

@@ -56,16 +56,9 @@ commands =
     {posargs}
 
 
-[testenv:tests_clone]
-commands =
-    bash -c "if [ ! -d "{toxinidir}/tests/common" ]; then \
-               git clone https://git.openstack.org/openstack/openstack-ansible-tests {toxinidir}/tests/common; \
-             fi"
-
-
 [testenv:pep8]
 commands =
-    {[testenv:tests_clone]commands}
+    bash -c "{toxinidir}/tests/tests-repo-clone.sh"
     bash -c "{toxinidir}/tests/common/test-pep8.sh"
 
 
@@ -78,7 +71,7 @@ ignore=F403
 
 [testenv:bashate]
 commands =
-    {[testenv:tests_clone]commands}
+    bash -c "{toxinidir}/tests/tests-repo-clone.sh"
     bash -c "{toxinidir}/tests/common/test-bashate.sh"
 
 
@@ -93,7 +86,7 @@ deps =
 deps =
     {[testenv:ansible]deps}
 commands =
-    {[testenv:tests_clone]commands}
+    bash -c "{toxinidir}/tests/tests-repo-clone.sh"
     bash -c "{toxinidir}/tests/common/test-ansible-syntax.sh"
 
 
@@ -101,7 +94,7 @@ commands =
 deps =
     {[testenv:ansible]deps}
 commands =
-    {[testenv:tests_clone]commands}
+    bash -c "{toxinidir}/tests/tests-repo-clone.sh"
     bash -c "{toxinidir}/tests/common/test-ansible-lint.sh"
 
 
@@ -109,7 +102,7 @@ commands =
 deps =
     {[testenv:ansible]deps}
 commands =
-    {[testenv:tests_clone]commands}
+    bash -c "{toxinidir}/tests/tests-repo-clone.sh"
     bash -c "{toxinidir}/tests/common/test-ansible-functional.sh"