openstack
/
openstack-ansible-pip_install
Code Issues Proposed changes

Fix usage of "|" for tests 

With the more recent versions of ansible, we should now use
"is" instead of the "|" sign for the tests.

This should fix it.

Change-Id: I950916695929d35dbf4606f4ef33f5ae559118c5
This commit is contained in:
Jean-Philippe Evrard 2018-07-12 16:44:21 +02:00
parent ccdc8c4575
commit 914fbc44cb
4 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
tasks/install_offline.yml
View File

@ -22,7 +22,7 @@
force: "yes" force: "yes"
validate_certs: "{{ pip_validate_certs }}" validate_certs: "{{ pip_validate_certs }}"
register: get_pip_local register: get_pip_local
until: get_pip_local | success until: get_pip_local is success
retries: 5 retries: 5
delay: 2 delay: 2
run_once: yes run_once: yes
@ -40,9 +40,9 @@
dest: "/tmp/get-pip.py" dest: "/tmp/get-pip.py"
force: "yes" force: "yes"
validate_certs: "{{ pip_validate_certs }}" validate_certs: "{{ pip_validate_certs }}"
when: get_pip_local | failed when: get_pip_local is failed
register: get_pip_local_fallback register: get_pip_local_fallback
until: get_pip_local_fallback | success until: get_pip_local_fallback is success
retries: 5 retries: 5
delay: 2 delay: 2
run_once: yes run_once: yes
@ -73,7 +73,7 @@
{{ pip_packages | map('quote') | join (' ') }} {{ pip_packages | map('quote') | join (' ') }}
changed_when: pip_local_cache.stdout.find('Successfully downloaded') != -1 changed_when: pip_local_cache.stdout.find('Successfully downloaded') != -1
register: pip_local_cache register: pip_local_cache
until: pip_local_cache | success until: pip_local_cache is success
retries: 3 retries: 3
delay: 2 delay: 2
notify: notify:

6
tasks/install_online.yml
View File

@ -21,7 +21,7 @@
force: "{{ pip_get_pip_force | bool }}" force: "{{ pip_get_pip_force | bool }}"
validate_certs: "{{ pip_validate_certs }}" validate_certs: "{{ pip_validate_certs }}"
register: get_pip register: get_pip
until: get_pip | success until: get_pip is success
retries: 5 retries: 5
delay: 2 delay: 2
tags: tags:
@ -34,9 +34,9 @@
dest: "/opt/get-pip.py" dest: "/opt/get-pip.py"
force: "{{ pip_get_pip_force | bool }}" force: "{{ pip_get_pip_force | bool }}"
validate_certs: "{{ pip_validate_certs }}" validate_certs: "{{ pip_validate_certs }}"
when: get_pip | failed when: get_pip is failed
register: get_pip_fallback register: get_pip_fallback
until: get_pip_fallback | success until: get_pip_fallback is success
retries: 5 retries: 5
delay: 2 delay: 2
tags: tags:

4
tasks/install_source.yml
View File

@ -23,7 +23,7 @@
{{ pip_packages | map('quote') | join (' ') }} {{ pip_packages | map('quote') | join (' ') }}
changed_when: pip_install.stdout.find('Successfully installed') != -1 changed_when: pip_install.stdout.find('Successfully installed') != -1
register: pip_install register: pip_install
until: pip_install | success until: pip_install is success
retries: 3 retries: 3
delay: 2 delay: 2
@ -38,6 +38,6 @@
{{ pip_packages | map('quote') | join (' ') }} {{ pip_packages | map('quote') | join (' ') }}
changed_when: pip_install_fall_back.stdout.find('Successfully installed') != -1 changed_when: pip_install_fall_back.stdout.find('Successfully installed') != -1
register: pip_install_fall_back register: pip_install_fall_back
until: pip_install_fall_back | success until: pip_install_fall_back is success
retries: 3 retries: 3
delay: 2 delay: 2

2
tasks/pre_install.yml
View File

@ -18,6 +18,6 @@
name: "{{ pip_install_distro_packages }}" name: "{{ pip_install_distro_packages }}"
state: "{{ pip_install_package_state }}" state: "{{ pip_install_package_state }}"
register: install_packages register: install_packages
until: install_packages|success until: install_packages is success
retries: 5 retries: 5
delay: 2 delay: 2