From aba329b6009d1d034b6cbb47c95d443e5e8cc9d6 Mon Sep 17 00:00:00 2001
From: Dmitriy Rabotyagov <dmitriy.rabotyagov@cleura.com>
Date: Mon, 25 Mar 2024 19:22:59 +0100
Subject: [PATCH] Rename _oslomsg_configure_* to _oslomsg_*_configure

In order to align naming convention for variables to be in the format
of `_oslo_<type>_<variable`  we are renaming 2 variables that are intended
for more or less internal use, which are _oslomsg_configure_rpc
and _oslomsg_configure_notify to _oslomsg_rpc_configure and
_oslomsg_notify_configure corresponsively.

Change-Id: Ic9f23e12f765f6c5881bb83c9c65a03b7ebef932
---
 ...oslomsg_configure_rename-bdd7b8b2fc97a5cc.yaml | 15 +++++++++++++++
 roles/mq_setup/tasks/main.yml                     |  4 ++--
 2 files changed, 17 insertions(+), 2 deletions(-)
 create mode 100644 releasenotes/notes/oslomsg_configure_rename-bdd7b8b2fc97a5cc.yaml

diff --git a/releasenotes/notes/oslomsg_configure_rename-bdd7b8b2fc97a5cc.yaml b/releasenotes/notes/oslomsg_configure_rename-bdd7b8b2fc97a5cc.yaml
new file mode 100644
index 00000000..bc2f6a42
--- /dev/null
+++ b/releasenotes/notes/oslomsg_configure_rename-bdd7b8b2fc97a5cc.yaml
@@ -0,0 +1,15 @@
+---
+
+upgrade:
+  - |
+    Variables ``_oslomsg_configure_rpc`` and ``_oslomsg_configure_notify``
+    renamed to ``_oslomsg_rpc_configure`` and ``_oslomsg_notify_configure``
+    corresponsively to align variables naming convention in the role.
+
+    Old variable names are not used or respected anymore.
+
+deprecations:
+  - |
+    Variables ``_oslomsg_configure_rpc`` and ``_oslomsg_configure_notify`` are
+    deprecated in favor of ``_oslomsg_rpc_configure`` and
+    ``_oslomsg_notify_configure``.
diff --git a/roles/mq_setup/tasks/main.yml b/roles/mq_setup/tasks/main.yml
index 1fb7c467..6ef18043 100644
--- a/roles/mq_setup/tasks/main.yml
+++ b/roles/mq_setup/tasks/main.yml
@@ -34,7 +34,7 @@
       loop_control:
         loop_var: __mq_vhost
   when:
-    - "(_oslomsg_configure_rpc | default(_oslomsg_rpc_transport is defined))"
+    - "(_oslomsg_rpc_configure | default(_oslomsg_rpc_transport is defined))"
     - "(_oslomsg_rpc_transport is defined) and (_oslomsg_rpc_transport == 'rabbit')"
   tags:
     - common-rabbitmq
@@ -42,7 +42,7 @@
 - name: Setup Notify MQ Service (RabbitMQ)
   delegate_to: "{{ _oslomsg_notify_setup_host }}"
   when:
-    - "(_oslomsg_configure_notify | default(_oslomsg_notify_transport is defined))"
+    - "(_oslomsg_notify_configure | default(_oslomsg_notify_transport is defined))"
     - "(_oslomsg_notify_transport is defined) and (_oslomsg_notify_transport == 'rabbit')"
   tags:
     - common-rabbitmq